Subject: Re: [PATCH net v2 2/4] bnxt_en: Fix skb recycling logic in bnxt_deliver_skb()

From: Jakub Kicinski <[email-masked]>
Date: Thu, 7 Dec 2023 10:21:44 -0800

On Wed,  6 Dec 2023 16:05:49 -0800 Michael Chan wrote:
> Receive SKBs can go through the VF-rep path or the normal path.
> skb_mark_for_recycle() is only called for the normal path.  Fix it
> to do it for both paths to fix possible stalled page pool shutdown
> errors.

This patch is probably fine, but since I'm complaining -
IMHO it may be better to mark the skbs right after they
are allocated. Catching all "exit points" seems very error
prone...