Subject: Re: [PATCH iwl-net v2] ice: Do not get coalesce settings while in reset

From: Simon Horman <[email-masked]>
Date: Sun, 10 Dec 2023 11:54:14 +0000

On Wed, Dec 06, 2023 at 06:39:36PM +0100, Pawel Chmielewski wrote:
> From: Ngai-Mint Kwan <[email-masked]>
> 
> Getting coalesce settings while reset is in progress can cause NULL
> pointer deference bug.
> If under reset, abort get coalesce for ethtool.
> 
> Fixes: 67fe64d78c437 ("ice: Implement getting and setting ethtool coalesce")
> Signed-off-by: Ngai-Mint Kwan <[email-masked]>
> Reviewed-by: Mateusz Polchlopek <[email-masked]>
> Signed-off-by: Pawel Chmielewski <[email-masked]>
> ---
> Changes since v1:
>  * Added "Fixes:" tag
>  * targeting iwl-net instead of iwl-next

Thanks for the update.

Reviewed-by: Simon Horman <[email-masked]>