From: Simon Horman <horms@kernel•org>
To: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
kernel test robot <lkp@intel•com>
Subject: Re: [PATCH net-next v1 1/1] net: dl2k: Use proper conversion of dev_addr before IO to device
Date: Tue, 12 Dec 2023 11:23:44 +0000 [thread overview]
Message-ID: <20231212112344.GZ5817@kernel.org> (raw)
In-Reply-To: <20231208153327.3306798-1-andriy.shevchenko@linux.intel.com>
On Fri, Dec 08, 2023 at 05:33:27PM +0200, Andy Shevchenko wrote:
> The driver is using iowriteXX()/ioreadXX() APIs which are LE IO
> accessors simplified as
>
> 1. Convert given value _from_ CPU _to_ LE
> 2. Write it to the device as is
>
> The dev_addr is a byte stream, but because the driver uses 16-bit
> IO accessors, it wants to perform double conversion on BE CPUs,
> but it took it wrong, as it effectivelly does two times _from_ CPU
> _to_ LE. What it has to do is to consider dev_addr as an array of
> LE16 and hence do _from_ LE _to_ CPU conversion, followed by implied
> _from_ CPU _to_ LE in the iowrite16().
>
> To achieve that, use get_unaligned_le16(). This will make it correct
> and allows to avoid sparse warning as reported by LKP.
>
> Reported-by: kernel test robot <lkp@intel•com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312030058.hfZPTXd7-lkp@intel.com/
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
Thanks Andy,
I agree with your reasoning that the explicit conversion is reversed.
Reviewed-by: Simon Horman <horms@kernel•org>
prev parent reply other threads:[~2023-12-12 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 15:33 [PATCH net-next v1 1/1] net: dl2k: Use proper conversion of dev_addr before IO to device Andy Shevchenko
2023-12-12 10:40 ` patchwork-bot+netdevbpf
2023-12-12 11:23 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212112344.GZ5817@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lkp@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox