From: Jakub Kicinski <kuba@kernel•org>
To: Jiawen Wu <jiawenwu@trustnetic•com>
Cc: davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
linux@armlinux•org.uk, andrew@lunn•ch, netdev@vger•kernel.org,
mengyuanlou@net-swift•com
Subject: Re: [PATCH net-next v5 7/8] net: wangxun: add ethtool_ops for channel number
Date: Fri, 15 Dec 2023 18:41:07 -0800 [thread overview]
Message-ID: <20231215184107.1eaa8a95@kernel.org> (raw)
In-Reply-To: <20231214025456.1387175-8-jiawenwu@trustnetic.com>
On Thu, 14 Dec 2023 10:54:55 +0800 Jiawen Wu wrote:
> + if (!(wx->msix_q_entries)) {
pointless brackets
> +void wx_get_channels(struct net_device *dev,
> + struct ethtool_channels *ch)
> +{
> + struct wx *wx = netdev_priv(dev);
> +
> + /* report maximum channels */
> + ch->max_combined = wx_max_channels(wx);
> +
> + /* report info for other vector */
> + if (wx->msix_q_entries) {
> + ch->max_other = 1;
> + ch->other_count = 1;
> + }
> +
> + /* record RSS queues */
> + ch->combined_count = wx->ring_feature[RING_F_RSS].indices;
> +
> + /* nothing else to report if RSS is disabled */
> + if (ch->combined_count == 1)
> + return;
pointless return
> +}
> +EXPORT_SYMBOL(wx_get_channels);
> +
> +int wx_set_channels(struct net_device *dev,
> + struct ethtool_channels *ch)
> +{
> + unsigned int count = ch->combined_count;
> + struct wx *wx = netdev_priv(dev);
> +
> + /* verify they are not requesting separate vectors */
> + if (!count || ch->rx_count || ch->tx_count)
> + return -EOPNOTSUPP;
core shouldn't allow this to reach you
next prev parent reply other threads:[~2023-12-16 2:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 2:54 [PATCH net-next v5 0/8] Implement more ethtool_ops for Wangxun Jiawen Wu
2023-12-14 2:54 ` [PATCH net-next v5 1/8] net: libwx: add phylink to libwx Jiawen Wu
2023-12-14 2:54 ` [PATCH net-next v5 2/8] net: txgbe: use phylink bits added in libwx Jiawen Wu
2023-12-14 2:54 ` [PATCH net-next v5 3/8] net: ngbe: convert phylib to phylink Jiawen Wu
2023-12-14 2:54 ` [PATCH net-next v5 4/8] net: wangxun: add flow control support Jiawen Wu
2023-12-14 2:54 ` [PATCH net-next v5 5/8] net: wangxun: add ethtool_ops for ring parameters Jiawen Wu
2023-12-16 2:36 ` Jakub Kicinski
2023-12-14 2:54 ` [PATCH net-next v5 6/8] net: wangxun: add coalesce options support Jiawen Wu
2023-12-16 2:38 ` Jakub Kicinski
2023-12-22 8:20 ` Jiawen Wu
2023-12-14 2:54 ` [PATCH net-next v5 7/8] net: wangxun: add ethtool_ops for channel number Jiawen Wu
2023-12-16 2:41 ` Jakub Kicinski [this message]
2023-12-14 2:54 ` [PATCH net-next v5 8/8] net: wangxun: add ethtool_ops for msglevel Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215184107.1eaa8a95@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jiawenwu@trustnetic$(echo .)com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox