From: Jakub Kicinski <kuba@kernel•org>
To: Shakeel Butt <shakeelb@google•com>
Cc: "Mina Almasry" <almasrymina@google•com>,
"Yunsheng Lin" <linyunsheng@huawei•com>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
bpf@vger•kernel.org, "Thomas Gleixner" <tglx@linutronix•de>,
"Ingo Molnar" <mingo@redhat•com>,
"Borislav Petkov" <bp@alien8•de>,
"Dave Hansen" <dave.hansen@linux•intel.com>,
x86@kernel•org, "H. Peter Anvin" <hpa@zytor•com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Rafael J. Wysocki" <rafael@kernel•org>,
"Sumit Semwal" <sumit.semwal@linaro•org>,
"Christian König" <christian.koenig@amd•com>,
"Michael Chan" <michael.chan@broadcom•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Alexei Starovoitov" <ast@kernel•org>,
"Daniel Borkmann" <daniel@iogearbox•net>,
"Jesper Dangaard Brouer" <hawk@kernel•org>,
"John Fastabend" <john.fastabend@gmail•com>,
"Wei Fang" <wei.fang@nxp•com>,
"Shenwei Wang" <shenwei.wang@nxp•com>,
"Clark Wang" <xiaoning.wang@nxp•com>,
"NXP Linux Team" <linux-imx@nxp•com>,
"Jeroen de Borst" <jeroendb@google•com>,
"Praveen Kaligineedi" <pkaligineedi@google•com>,
"Shailend Chand" <shailend@google•com>,
"Yisen Zhuang" <yisen.zhuang@huawei•com>,
"Salil Mehta" <salil.mehta@huawei•com>,
"Jesse Brandeburg" <jesse.brandeburg@intel•com>,
"Tony Nguyen" <anthony.l.nguyen@intel•com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin•com>,
"Marcin Wojtas" <mw@semihalf•com>,
"Russell King" <linux@armlinux•org.uk>,
"Sunil Goutham" <sgoutham@marvell•com>,
"Geetha sowjanya" <gakula@marvell•com>,
"Subbaraya Sundeep" <sbhatta@marvell•com>,
hariprasad <hkelam@marvell•com>, "Felix Fietkau" <nbd@nbd•name>,
"John Crispin" <john@phrozen•org>,
"Sean Wang" <sean.wang@mediatek•com>,
"Mark Lee" <Mark-MC.Lee@mediatek•com>,
"Lorenzo Bianconi" <lorenzo@kernel•org>,
"Matthias Brugger" <matthias.bgg@gmail•com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora•com>,
"Saeed Mahameed" <saeedm@nvidia•com>,
"Leon Romanovsky" <leon@kernel•org>,
"Horatiu Vultur" <horatiu.vultur@microchip•com>,
UNGLinuxDriver@microchip•com,
"K. Y. Srinivasan" <kys@microsoft•com>,
"Haiyang Zhang" <haiyangz@microsoft•com>,
"Wei Liu" <wei.liu@kernel•org>,
"Dexuan Cui" <decui@microsoft•com>,
"Jassi Brar" <jaswinder.singh@linaro•org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro•org>,
"Alexandre Torgue" <alexandre.torgue@foss•st.com>,
"Jose Abreu" <joabreu@synopsys•com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail•com>,
"Siddharth Vadapalli" <s-vadapalli@ti•com>,
"Ravi Gunasekaran" <r-gunasekaran@ti•com>,
"Roger Quadros" <rogerq@kernel•org>,
"Jiawen Wu" <jiawenwu@trustnetic•com>,
"Mengyuan Lou" <mengyuanlou@net-swift•com>,
"Ronak Doshi" <doshir@vmware•com>,
"VMware PV-Drivers Reviewers" <pv-drivers@vmware•com>,
"Ryder Lee" <ryder.lee@mediatek•com>,
"Shayne Chen" <shayne.chen@mediatek•com>,
"Kalle Valo" <kvalo@kernel•org>,
"Juergen Gross" <jgross@suse•com>,
"Stefano Stabellini" <sstabellini@kernel•org>,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam•com>,
"Andrii Nakryiko" <andrii@kernel•org>,
"Martin KaFai Lau" <martin.lau@linux•dev>,
"Song Liu" <song@kernel•org>,
"Yonghong Song" <yonghong.song@linux•dev>,
"KP Singh" <kpsingh@kernel•org>,
"Stanislav Fomichev" <sdf@google•com>,
"Hao Luo" <haoluo@google•com>, "Jiri Olsa" <jolsa@kernel•org>,
"Stefan Hajnoczi" <stefanha@redhat•com>,
"Stefano Garzarella" <sgarzare@redhat•com>,
"Shuah Khan" <shuah@kernel•org>,
" Mickaël Salaün" <mic@digikod•net>,
"Nathan Chancellor" <nathan@kernel•org>,
"Nick Desaulniers" <ndesaulniers@google•com>,
"Bill Wendling" <morbo@google•com>,
"Justin Stitt" <justinstitt@google•com>,
"Jason Gunthorpe" <jgg@nvidia•com>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail•com>
Subject: Re: [RFC PATCH net-next v1 4/4] net: page_pool: use netmem_t instead of struct page in API
Date: Fri, 15 Dec 2023 19:01:26 -0800 [thread overview]
Message-ID: <20231215190126.1040fa12@kernel.org> (raw)
In-Reply-To: <20231215021114.ipvdx2bwtxckrfdg@google.com>
On Fri, 15 Dec 2023 02:11:14 +0000 Shakeel Butt wrote:
> > From my POV it has to be the first one. We want to abstract the memory
> > type from the drivers as much as possible, not introduce N new memory
> > types and ask the driver to implement new code for each of them
> > separately.
>
> Agree with Mina's point. Let's aim to decouple memory types from
> drivers.
What does "decouple" mean? Drivers should never convert netmem
to pages. Either a path in the driver can deal with netmem,
i.e. never touch the payload, or it needs pages.
Perhaps we should aim to not export netmem_to_page(),
prevent modules from accessing it directly.
next prev parent reply other threads:[~2023-12-16 3:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 2:05 [RFC PATCH net-next v1 0/4] Abstract page from net stack Mina Almasry
2023-12-14 2:05 ` [RFC PATCH net-next v1 1/4] vsock/virtio: use skb_frag_page() helper Mina Almasry
2023-12-14 6:27 ` David Ahern
2023-12-14 8:19 ` Stefano Garzarella
2023-12-14 2:05 ` [RFC PATCH net-next v1 2/4] net: introduce abstraction for network memory Mina Almasry
2023-12-14 6:34 ` David Ahern
2023-12-16 2:51 ` Jakub Kicinski
2023-12-16 22:10 ` Mina Almasry
2023-12-17 1:45 ` David Ahern
2023-12-17 8:14 ` Mina Almasry
2023-12-18 22:06 ` Jakub Kicinski
2023-12-18 22:38 ` Mina Almasry
2023-12-19 17:27 ` Shakeel Butt
2023-12-14 2:05 ` [RFC PATCH net-next v1 3/4] net: add netmem_t to skb_frag_t Mina Almasry
2023-12-14 2:05 ` [RFC PATCH net-next v1 4/4] net: page_pool: use netmem_t instead of struct page in API Mina Almasry
2023-12-14 12:05 ` Yunsheng Lin
2023-12-14 16:27 ` Mina Almasry
2023-12-15 2:11 ` Shakeel Butt
2023-12-15 11:04 ` Yunsheng Lin
2023-12-15 16:47 ` Shakeel Butt
2023-12-16 3:01 ` Jakub Kicinski [this message]
2023-12-16 19:46 ` Shakeel Butt
2023-12-16 22:06 ` Mina Almasry
2023-12-20 3:01 ` Mina Almasry
2023-12-21 11:32 ` Yunsheng Lin
2023-12-21 21:22 ` Mina Almasry
2023-12-22 6:42 ` Yunsheng Lin
2024-01-02 16:14 ` Mina Almasry
2024-01-03 9:47 ` Yunsheng Lin
2024-01-03 18:38 ` Mina Almasry
2024-01-04 8:48 ` Yunsheng Lin
2024-01-04 18:24 ` Mina Almasry
2024-01-05 8:40 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215190126.1040fa12@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=Mark-MC.Lee@mediatek$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=almasrymina@google$(echo .)com \
--cc=andrii@kernel$(echo .)org \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bp@alien8$(echo .)de \
--cc=bpf@vger$(echo .)kernel.org \
--cc=christian.koenig@amd$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=doshir@vmware$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=haiyangz@microsoft$(echo .)com \
--cc=haoluo@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=hkelam@marvell$(echo .)com \
--cc=horatiu.vultur@microchip$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=jaswinder.singh@linaro$(echo .)org \
--cc=jeroendb@google$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jgg@nvidia$(echo .)com \
--cc=jgross@suse$(echo .)com \
--cc=jiawenwu@trustnetic$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=jolsa@kernel$(echo .)org \
--cc=justinstitt@google$(echo .)com \
--cc=kpsingh@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linyunsheng@huawei$(echo .)com \
--cc=lorenzo@kernel$(echo .)org \
--cc=martin.lau@linux$(echo .)dev \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=mic@digikod$(echo .)net \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=morbo@google$(echo .)com \
--cc=mw@semihalf$(echo .)com \
--cc=nathan@kernel$(echo .)org \
--cc=nbd@nbd$(echo .)name \
--cc=ndesaulniers@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oleksandr_tyshchenko@epam$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pkaligineedi@google$(echo .)com \
--cc=pv-drivers@vmware$(echo .)com \
--cc=r-gunasekaran@ti$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=rogerq@kernel$(echo .)org \
--cc=ryder.lee@mediatek$(echo .)com \
--cc=s-vadapalli@ti$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sdf@google$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=sgarzare@redhat$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=shailend@google$(echo .)com \
--cc=shakeelb@google$(echo .)com \
--cc=shayne.chen@mediatek$(echo .)com \
--cc=shenwei.wang@nxp$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=song@kernel$(echo .)org \
--cc=sstabellini@kernel$(echo .)org \
--cc=stefanha@redhat$(echo .)com \
--cc=sumit.semwal@linaro$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=wei.fang@nxp$(echo .)com \
--cc=wei.liu@kernel$(echo .)org \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=xiaoning.wang@nxp$(echo .)com \
--cc=yisen.zhuang@huawei$(echo .)com \
--cc=yonghong.song@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox