Subject: Re: [PATCH] net: mana: select PAGE_POOL

From: Simon Horman <[email-masked]>
Date: Mon, 18 Dec 2023 10:50:26 +0000

On Fri, Dec 15, 2023 at 12:33:53PM -0800, Yury Norov wrote:
> Mana uses PAGE_POOL API. x86_64 defconfig doesn't select it:
> 
> ld: vmlinux.o: in function `mana_create_page_pool.isra.0':
> mana_en.c:(.text+0x9ae36f): undefined reference to `page_pool_create'
> ld: vmlinux.o: in function `mana_get_rxfrag':
> mana_en.c:(.text+0x9afed1): undefined reference to `page_pool_alloc_pages'
> make[3]: *** [/home/yury/work/linux/scripts/Makefile.vmlinux:37: vmlinux] Error 1
> make[2]: *** [/home/yury/work/linux/Makefile:1154: vmlinux] Error 2
> make[1]: *** [/home/yury/work/linux/Makefile:234: __sub-make] Error 2
> make[1]: Leaving directory '/home/yury/work/build-linux-x86_64'
> make: *** [Makefile:234: __sub-make] Error 2
> 
> So we need to select it explicitly.
> 
> Signed-off-by: Yury Norov <[email-masked]>

Reviewed-by: Simon Horman <[email-masked]>
Tested-by: Simon Horman <[email-masked]> # build-tested