From: Jakub Kicinski <kuba@kernel•org>
To: Hangbin Liu <liuhangbin@gmail•com>
Cc: netdev@vger•kernel.org, Paolo Abeni <pabeni@redhat•com>
Subject: Re: [PATCH net-next 2/3] tools: ynl-gen: support using defines in checks
Date: Mon, 18 Dec 2023 14:23:10 -0800 [thread overview]
Message-ID: <20231218142310.1f10f8f4@kernel.org> (raw)
In-Reply-To: <ZX1jbgQ3lgQtkF02@Laptop-X1>
On Sat, 16 Dec 2023 16:44:30 +0800 Hangbin Liu wrote:
> On Fri, Dec 15, 2023 at 06:08:24PM -0800, Jakub Kicinski wrote:
> > On Fri, 15 Dec 2023 11:50:08 +0800 Hangbin Liu wrote:
> > > - pattern: ^[0-9A-Za-z_]+( - 1)?$
> > > + pattern: ^[0-9A-Za-z_-]+( - 1)?$
> >
> > Why the '-' ? Could you add an example of the define you're trying to
> > match to the commit message?
> For team driver, there is a define like:
>
> #define TEAM_STRING_MAX_LEN 32
>
> So I'd like to define it in yaml like:
>
> definitions:
> -
> name: string-max-len
> type: const
> value: 32
>
> And use it in the attribute-sets like
>
> attribute-sets:
> -
> name: attr-option
> name-prefix: team-attr-option-
> attributes:
> -
> name: unspec
> type: unused
> value: 0
> -
> name: name
> type: string
> checks:
> len: string-max-len
>
> With this patch it will be converted to
>
> [TEAM_ATTR_OPTION_NAME] = { .type = NLA_STRING, .len = TEAM_STRING_MAX_LEN, }
Ah, I see. The spec match needs to work on names before they go thru
c_upper(). The patch makes sense:
Reviewed-by: Jakub Kicinski <kuba@kernel•org>
next prev parent reply other threads:[~2023-12-18 22:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 3:50 [PATCH net-next 0/3] ynl-gen: update check format Hangbin Liu
2023-12-15 3:50 ` [PATCH net-next 1/3] tools: ynl-gen: use correct len for string and binary Hangbin Liu
2023-12-16 2:06 ` Jakub Kicinski
2023-12-16 8:35 ` Hangbin Liu
2023-12-18 22:22 ` Jakub Kicinski
2023-12-19 10:01 ` Hangbin Liu
2023-12-15 3:50 ` [PATCH net-next 2/3] tools: ynl-gen: support using defines in checks Hangbin Liu
2023-12-16 2:08 ` Jakub Kicinski
2023-12-16 8:44 ` Hangbin Liu
2023-12-18 22:23 ` Jakub Kicinski [this message]
2023-12-15 3:50 ` [PATCH net-next 3/3] netlink: specs: use exact-len for IPv6 addr Hangbin Liu
2023-12-16 2:09 ` Jakub Kicinski
2023-12-16 8:48 ` Hangbin Liu
2023-12-18 22:24 ` Jakub Kicinski
2023-12-18 11:40 ` Davide Caratti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218142310.1f10f8f4@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=liuhangbin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox