Subject: Re: [PATCH iwl-next v5 1/2] ixgbe: Refactor overtemp event handling

From: Simon Horman <[email-masked]>
Date: Tue, 19 Dec 2023 11:05:33 +0000

On Mon, Dec 18, 2023 at 11:39:25AM +0100, Jedrzej Jagielski wrote:
> Currently ixgbe driver is notified of overheating events
> via internal IXGBE_ERR_OVERTEMP error code.
> 
> Change the approach for handle_lasi() to use freshly introduced
> is_overtemp function parameter which set when such event occurs.
> Change check_overtemp() to bool and return true if overtemp
> event occurs.
> 
> Reviewed-by: Przemek Kitszel <[email-masked]>
> Signed-off-by: Jedrzej Jagielski <[email-masked]>
> ---
> v2: change aproach to use additional function parameter to notify when overheat
> v4: change check_overtemp to bool
> v5: adress Simon's comments

Hi Jedrzej,

Thanks for the updates, this version looks good to me.

Reviewed-by: Simon Horman <[email-masked]>