Subject: Re: [PATCH iproute2-next 03/20] bridge: vni: Fix duplicate group and remote error messages

From: Stephen Hemminger <[email-masked]>
Date: Wed, 20 Dec 2023 19:59:07 -0800

On Mon, 11 Dec 2023 09:07:15 -0500
Benjamin Poirier <[email-masked]> wrote:

> Consider the following command with a duplicated "remote" argument:
> $ bridge vni add vni 150 remote 10.0.0.1 remote 10.0.0.2 dev vxlan2
> Error: argument "remote" is wrong: duplicate group
> 
> The error message is misleading because there is no "group" argument. Both
> of the "group" and "remote" options specify a destination address and are
> mutually exclusive so change the variable name and error messages
> accordingly.
> 
> The result is:
> $ ./bridge/bridge vni add vni 150 remote 10.0.0.1 remote 10.0.0.2 dev vxlan2
> Error: duplicate "destination": "10.0.0.2" is the second value.
> 
> Fixes: 45cd32f9f7d5 ("bridge: vxlan device vnifilter support")
> Reviewed-by: Petr Machata <[email-masked]>
> Tested-by: Petr Machata <[email-masked]>
> Signed-off-by: Benjamin Poirier <[email-masked]>
> ---

Acked-by: Stephen Hemminger <[email-masked]>