Subject: Re: [PATCH iproute2-next 01/20] bridge: vni: Accept 'del' command

From: Stephen Hemminger <[email-masked]>
Date: Thu, 21 Dec 2023 08:06:24 -0800

On Wed, 20 Dec 2023 19:57:08 -0800
Stephen Hemminger <[email-masked]> wrote:

> On Mon, 11 Dec 2023 09:07:13 -0500
> Benjamin Poirier <[email-masked]> wrote:
> 
> > `bridge vni help` shows "bridge vni { add | del } ..." but currently
> > `bridge vni del ...` errors out unexpectedly:
> > 	# bridge vni del
> > 	Command "del" is unknown, try "bridge vni help".
> > 
> > Recognize 'del' as a synonym of the original 'delete' command.
> > 
> > Fixes: 45cd32f9f7d5 ("bridge: vxlan device vnifilter support")
> > Reviewed-by: Petr Machata <[email-masked]>
> > Tested-by: Petr Machata <[email-masked]>
> > Signed-off-by: Benjamin Poirier <[email-masked]>  
> 
> Please no.
> We are blocking uses of matches() and now other commands will want more synonyms
> Instead fix the help and doc.

I changed my mind. This is fine. The commands in iproute2 are inconsistent (no surprise)
and plenty of places take del (and not delete??)