From: Jakub Kicinski <kuba@kernel•org>
To: Ahmed Zaki <ahmed.zaki@intel•com>
Cc: netdev@vger•kernel.org, corbet@lwn•net,
jesse.brandeburg@intel•com, anthony.l.nguyen@intel•com,
davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
vladimir.oltean@nxp•com, andrew@lunn•ch, horms@kernel•org,
mkubecek@suse•cz, willemdebruijn.kernel@gmail•com,
gal@nvidia•com, alexander.duyck@gmail•com,
ecree.xilinx@gmail•com, Jacob Keller <jacob.e.keller@intel•com>
Subject: Re: [PATCH net-next 2/2] net: ethtool: add a NO_CHANGE uAPI for new RXFH's input_xfrm
Date: Tue, 2 Jan 2024 16:05:26 -0800 [thread overview]
Message-ID: <20240102160526.6178fd04@kernel.org> (raw)
In-Reply-To: <20231221184235.9192-3-ahmed.zaki@intel.com>
On Thu, 21 Dec 2023 11:42:35 -0700 Ahmed Zaki wrote:
> + rxfh.key_size == 0 && rxfh.hfunc == ETH_RSS_HASH_NO_CHANGE &&
> + rxfh.input_xfrm == RXH_XFRM_NO_CHANGE))
This looks fine, but we also need a check to make sure input_xfrm
doesn't have bits other than RXH_XFRM_SYM_XOR set, right?
next prev parent reply other threads:[~2024-01-03 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 18:42 [PATCH net-next 0/2] Bug fixes for RSS symmetric-xor Ahmed Zaki
2023-12-21 18:42 ` [PATCH net-next 1/2] net: ethtool: copy input_xfrm to user-space in ethtool_get_rxfh Ahmed Zaki
2023-12-21 18:42 ` [PATCH net-next 2/2] net: ethtool: add a NO_CHANGE uAPI for new RXFH's input_xfrm Ahmed Zaki
2024-01-03 0:05 ` Jakub Kicinski [this message]
2024-01-03 15:40 ` Ahmed Zaki
2024-01-03 22:16 ` Jakub Kicinski
2024-01-03 0:10 ` [PATCH net-next 0/2] Bug fixes for RSS symmetric-xor patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240102160526.6178fd04@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ahmed.zaki@intel$(echo .)com \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox