From: Christian Marangi <ansuelsmth@gmail•com>
To: "Pavel Machek" <pavel@ucw•cz>, "Lee Jones" <lee@kernel•org>,
"Rob Herring" <robh+dt@kernel•org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro•org>,
"Conor Dooley" <conor+dt@kernel•org>,
"William Zhang" <william.zhang@broadcom•com>,
"Anand Gore" <anand.gore@broadcom•com>,
"Kursad Oney" <kursad.oney@broadcom•com>,
"Florian Fainelli" <florian.fainelli@broadcom•com>,
"Rafał Miłecki" <rafal@milecki•pl>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>, "Andrew Lunn" <andrew@lunn•ch>,
"Heiner Kallweit" <hkallweit1@gmail•com>,
"Russell King" <linux@armlinux•org.uk>,
"Jacek Anaszewski" <jacek.anaszewski@gmail•com>,
"Fernández Rojas" <noltari@gmail•com>,
"Sven Schwermer" <sven.schwermer@disruptive-technologies•com>,
"Christian Marangi" <ansuelsmth@gmail•com>,
linux-leds@vger•kernel.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, netdev@vger•kernel.org
Subject: [net-next PATCH v6 1/5] dt-bindings: net: phy: Make LED active-low property common
Date: Tue, 2 Jan 2024 19:38:30 +0100 [thread overview]
Message-ID: <20240102183835.5332-2-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20240102183835.5332-1-ansuelsmth@gmail.com>
Move LED active-low property to common.yaml. This property is currently
defined multiple times by bcm LEDs. This property will now be supported
in a generic way for PHY LEDs with the use of a generic function.
With active-low bool property not defined, active-high is always
assumed.
Signed-off-by: Christian Marangi <ansuelsmth@gmail•com>
---
Changes v5:
- Make active-low generic
Changes v4:
- Drop support for global active-low
- Rework to polarity option (for marvell10g series support)
Changes v3:
- Out of RFC
Changes v2:
- Add this patch
Documentation/devicetree/bindings/leds/common.yaml | 6 ++++++
Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 4 ----
Documentation/devicetree/bindings/leds/leds-bcm6328.yaml | 4 ----
Documentation/devicetree/bindings/leds/leds-bcm6358.txt | 2 --
.../devicetree/bindings/leds/leds-pwm-multicolor.yaml | 4 ----
Documentation/devicetree/bindings/leds/leds-pwm.yaml | 5 -----
6 files changed, 6 insertions(+), 19 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index c8d0ba5f2327..f5b40df6b421 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -200,6 +200,12 @@ properties:
#trigger-source-cells property in the source node.
$ref: /schemas/types.yaml#/definitions/phandle-array
+ active-low:
+ type: boolean
+ description:
+ Makes LED active low. To turn the LED ON, line needs to be
+ set to low voltage instead of high.
+
# Required properties for flash LED child nodes:
flash-max-microamp:
description:
diff --git a/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml b/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml
index 52252fb6bb32..bb20394fca5c 100644
--- a/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml
@@ -52,10 +52,6 @@ patternProperties:
maxItems: 1
description: LED pin number
- active-low:
- type: boolean
- description: Makes LED active low
-
required:
- reg
diff --git a/Documentation/devicetree/bindings/leds/leds-bcm6328.yaml b/Documentation/devicetree/bindings/leds/leds-bcm6328.yaml
index 51cc0d82c12e..f3a3ef992929 100644
--- a/Documentation/devicetree/bindings/leds/leds-bcm6328.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-bcm6328.yaml
@@ -78,10 +78,6 @@ patternProperties:
- maximum: 23
description: LED pin number (only LEDs 0 to 23 are valid).
- active-low:
- type: boolean
- description: Makes LED active low.
-
brcm,hardware-controlled:
type: boolean
description: Makes this LED hardware controlled.
diff --git a/Documentation/devicetree/bindings/leds/leds-bcm6358.txt b/Documentation/devicetree/bindings/leds/leds-bcm6358.txt
index 6e51c6b91ee5..211ffc3c4a20 100644
--- a/Documentation/devicetree/bindings/leds/leds-bcm6358.txt
+++ b/Documentation/devicetree/bindings/leds/leds-bcm6358.txt
@@ -25,8 +25,6 @@ LED sub-node required properties:
LED sub-node optional properties:
- label : see Documentation/devicetree/bindings/leds/common.txt
- - active-low : Boolean, makes LED active low.
- Default : false
- default-state : see
Documentation/devicetree/bindings/leds/common.txt
- linux,default-trigger : see
diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
index bd6ec04a8727..5edfbe347341 100644
--- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
@@ -41,10 +41,6 @@ properties:
pwm-names: true
- active-low:
- description: For PWMs where the LED is wired to supply rather than ground.
- type: boolean
-
color: true
required:
diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.yaml b/Documentation/devicetree/bindings/leds/leds-pwm.yaml
index 7de6da58be3c..113b7c218303 100644
--- a/Documentation/devicetree/bindings/leds/leds-pwm.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-pwm.yaml
@@ -34,11 +34,6 @@ patternProperties:
Maximum brightness possible for the LED
$ref: /schemas/types.yaml#/definitions/uint32
- active-low:
- description:
- For PWMs where the LED is wired to supply rather than ground.
- type: boolean
-
required:
- pwms
- max-brightness
--
2.43.0
next prev parent reply other threads:[~2024-01-02 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 18:38 [net-next PATCH v6 0/5] net: phy: generic polarity + LED support for qca808x Christian Marangi
2024-01-02 18:38 ` Christian Marangi [this message]
2024-01-02 18:38 ` [net-next PATCH v6 2/5] dt-bindings: net: phy: Document LED inactive high impedance mode Christian Marangi
2024-01-02 18:38 ` [net-next PATCH v6 3/5] net: phy: add support for PHY LEDs polarity modes Christian Marangi
2024-01-02 18:38 ` [net-next PATCH v6 4/5] dt-bindings: net: Document QCA808x PHYs Christian Marangi
2024-01-02 18:38 ` [net-next PATCH v6 5/5] net: phy: at803x: add LED support for qca808x Christian Marangi
2024-01-03 16:59 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240102183835.5332-2-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail$(echo .)com \
--cc=anand.gore@broadcom$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jacek.anaszewski@gmail$(echo .)com \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kursad.oney@broadcom$(echo .)com \
--cc=lee@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=noltari@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=rafal@milecki$(echo .)pl \
--cc=robh+dt@kernel$(echo .)org \
--cc=sven.schwermer@disruptive-technologies$(echo .)com \
--cc=william.zhang@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox