From: Simon Horman <horms@kernel•org>
To: Shinas Rasheed <srasheed@marvell•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
hgani@marvell•com, vimleshk@marvell•com, sedara@marvell•com,
egallen@redhat•com, mschmidt@redhat•com, pabeni@redhat•com,
kuba@kernel•org, wizhao@redhat•com, kheib@redhat•com,
konguyen@redhat•com, "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jonathan Corbet <corbet@lwn•net>,
Veerasenareddy Burru <vburru@marvell•com>,
Satananda Burla <sburla@marvell•com>,
Shannon Nelson <shannon.nelson@amd•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
Alan Brady <alan.brady@intel•com>,
Rahul Rameshbabu <rrameshbabu@nvidia•com>,
Brett Creeley <brett.creeley@amd•com>,
Joshua Hay <joshua.a.hay@intel•com>, Andrew Lunn <andrew@lunn•ch>,
Jacob Keller <jacob.e.keller@intel•com>
Subject: Re: [PATCH net-next v2 1/8] octeon_ep_vf: Add driver framework and device initialization
Date: Fri, 5 Jan 2024 10:58:23 +0000 [thread overview]
Message-ID: <20240105105823.GT31813@kernel.org> (raw)
In-Reply-To: <20231223134000.2906144-2-srasheed@marvell.com>
On Sat, Dec 23, 2023 at 05:39:53AM -0800, Shinas Rasheed wrote:
> Add driver framework and device setup and initialization for Octeon
> PCI Endpoint NIC VF.
>
> Add implementation to load module, initialize, register network device,
> cleanup and unload module.
>
> Signed-off-by: Shinas Rasheed <srasheed@marvell•com>
Hi Shinas,
a minor nit from my side.
...
> diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
...
> +#ifndef UINT64_MAX
> +#define UINT64_MAX ((u64)(~((u64)0))) /* 0xFFFFFFFFFFFFFFFF */
> +#endif
nit: UINT64_MAX appears to be unused, so I think it can be removed.
Else, perhaps the code can be updated to use U64_MAX instead.
...
next prev parent reply other threads:[~2024-01-05 10:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 13:39 [PATCH net-next v2 0/8] add octeon_ep_vf driver Shinas Rasheed
2023-12-23 13:39 ` [PATCH net-next v2 1/8] octeon_ep_vf: Add driver framework and device initialization Shinas Rasheed
2024-01-05 10:58 ` Simon Horman [this message]
2023-12-23 13:39 ` [PATCH net-next v2 2/8] octeon_ep_vf: add hardware configuration APIs Shinas Rasheed
2024-01-05 10:22 ` Simon Horman
2023-12-23 13:39 ` [PATCH net-next v2 3/8] octeon_ep_vf: add VF-PF mailbox communication Shinas Rasheed
2023-12-23 13:39 ` [PATCH net-next v2 4/8] octeon_ep_vf: add Tx/Rx ring resource setup and cleanup Shinas Rasheed
2024-01-05 10:50 ` Simon Horman
2023-12-23 13:39 ` [PATCH net-next v2 5/8] octeon_ep_vf: add support for ndo ops Shinas Rasheed
2023-12-23 13:39 ` [PATCH net-next v2 6/8] octeon_ep_vf: add Tx/Rx processing and interrupt support Shinas Rasheed
2024-01-04 21:00 ` Jakub Kicinski
2024-01-05 7:26 ` [EXT] " Shinas Rasheed
2024-01-05 11:05 ` Simon Horman
2024-01-05 15:08 ` Shinas Rasheed
2023-12-23 13:39 ` [PATCH net-next v2 7/8] octeon_ep_vf: add ethtool support Shinas Rasheed
2024-01-04 20:53 ` Jakub Kicinski
2023-12-23 13:40 ` [PATCH net-next v2 8/8] octeon_ep_vf: update MAINTAINERS Shinas Rasheed
2024-01-02 14:30 ` [PATCH net-next v2 0/8] add octeon_ep_vf driver patchwork-bot+netdevbpf
2024-01-04 21:03 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240105105823.GT31813@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=alan.brady@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=brett.creeley@amd$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=egallen@redhat$(echo .)com \
--cc=hgani@marvell$(echo .)com \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=joshua.a.hay@intel$(echo .)com \
--cc=kheib@redhat$(echo .)com \
--cc=konguyen@redhat$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mschmidt@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rrameshbabu@nvidia$(echo .)com \
--cc=sburla@marvell$(echo .)com \
--cc=sedara@marvell$(echo .)com \
--cc=shannon.nelson@amd$(echo .)com \
--cc=srasheed@marvell$(echo .)com \
--cc=vburru@marvell$(echo .)com \
--cc=vimleshk@marvell$(echo .)com \
--cc=wizhao@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox