Subject: Re: [PATCH v2] net: dsa: vsc73xx: Add null pointer check to vsc73xx_gpio_probe

From: Simon Horman <[email-masked]>
Date: Thu, 11 Jan 2024 13:47:14 +0000

On Thu, Jan 11, 2024 at 03:20:18PM +0800, Kunwu Chan wrote:
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure.
> 
> Cc: Kunwu Chan <[email-masked]>
> Signed-off-by: Kunwu Chan <[email-masked]>
> Suggested-by: Jakub Kicinski <[email-masked]>

Hi Kunwu,

This seems to be a bug fix. If so it should have a fixes tag.
Perhaps this one is correct?

	Fixes: 05bd97fc559d ("net: dsa: Add Vitesse VSC73xx DSA router driver")

And, be targeted against net (as opposed to net-next)

	Subject: [PATCH net v2] ...

It is probably not necessary to repost to address these minor issues,
but please keep this in mind in future.

The above notwithstanding,

Reviewed-by: Simon Horman <[email-masked]>