From: Jakub Kicinski <kuba@kernel•org>
To: Romain Gantois <romain.gantois@bootlin•com>
Cc: Alexandre Torgue <alexandre.torgue@foss•st.com>,
Jose Abreu <joabreu@synopsys•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Miquel Raynal <miquel.raynal@bootlin•com>,
Maxime Chevallier <maxime.chevallier@bootlin•com>,
Sylvain Girard <sylvain.girard@se•com>,
Pascal EBERHARD <pascal.eberhard@se•com>,
Richard Tresidder <rtresidd@electromag•com.au>,
Linus Walleij <linus.walleij@linaro•org>,
Vladimir Oltean <olteanv@gmail•com>, Andrew Lunn <andrew@lunn•ch>,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
netdev@vger•kernel.org, linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, stable@vger•kernel.org,
Vladimir Oltean <vladimir.oltean@nxp•com>
Subject: Re: [PATCH net v5] net: stmmac: Prevent DSA tags from breaking COE
Date: Tue, 16 Jan 2024 07:23:00 -0800 [thread overview]
Message-ID: <20240116072300.3a6e0dbe@kernel.org> (raw)
In-Reply-To: <fca39a53-743e-f79d-d2d1-f23d8e919f82@bootlin.com>
On Tue, 16 Jan 2024 13:14:15 +0100 (CET) Romain Gantois wrote:
> > > @@ -4997,7 +5020,7 @@ static void stmmac_dispatch_skb_zc(struct stmmac_priv *priv, u32 queue,
> > > stmmac_rx_vlan(priv->dev, skb);
> > > skb->protocol = eth_type_trans(skb, priv->dev);
> > >
> > > - if (unlikely(!coe))
> > > + if (unlikely(!coe) || !stmmac_has_ip_ethertype(skb))
> >
> > The lack of Rx side COE checking in this driver is kinda crazy.
> > Looking at enh_desc_coe_rdes0() it seems like RDES0_FRAME_TYPE
> > may be the indication we need here?
>
> I don't think that RDES0_FRAME_TYPE would be enough, at least not on its own.
> That bit is set by checking the length/ethertype field to see if is an
> Ethernet II frame or an IEEE802.3 frame. But even Ethernet II frames with non-IP
> ethertypes will not be checksummed. Also protocols with a non-fixed ethertype
> field such as DSA_TAG_PROTO could trigger the bit, or not, depending on what
> they put in the DSA tag.
Hm, the comment in enh_desc_coe_rdes0() says:
/* bits 5 7 0 | Frame status
* ----------------------------------------------------------
* 0 0 0 | IEEE 802.3 Type frame (length < 1536 octects)
* 1 0 0 | IPv4/6 No CSUM errorS.
* 1 0 1 | IPv4/6 CSUM PAYLOAD error
* 1 1 0 | IPv4/6 CSUM IP HR error
* 1 1 1 | IPv4/6 IP PAYLOAD AND HEADER errorS
* 0 0 1 | IPv4/6 unsupported IP PAYLOAD
* 0 1 1 | COE bypassed.. no IPv4/6 frame
* 0 1 0 | Reserved.
*/
which makes it sound like bit 5 will not be set for a Ethernet II frame
with unsupported IP payload, or not an IP frame. Does the bit mean other
things in different descriptor formats?
next prev parent reply other threads:[~2024-01-16 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 14:58 [PATCH net v5] net: stmmac: Prevent DSA tags from breaking COE Romain Gantois
2024-01-13 2:13 ` Jakub Kicinski
2024-01-16 12:14 ` Romain Gantois
2024-01-16 15:23 ` Jakub Kicinski [this message]
2024-01-16 16:18 ` Romain Gantois
2024-01-16 18:36 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116072300.3a6e0dbe@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pascal.eberhard@se$(echo .)com \
--cc=romain.gantois@bootlin$(echo .)com \
--cc=rtresidd@electromag$(echo .)com.au \
--cc=stable@vger$(echo .)kernel.org \
--cc=sylvain.girard@se$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox