Subject: Re: [PATCH 1/3] selftests/net: Argument value mismatch when calling verify_counters()

From: Simon Horman <[email-masked]>
Date: Fri, 19 Jan 2024 16:26:52 +0000

On Thu, Jan 18, 2024 at 02:51:34AM +0000, Dmitry Safonov wrote:
> From: Mohammad Nassiri <[email-masked]>
> 
> The end_server() function only operates in the server thread
> and always takes an accept socket instead of a listen socket as
> its input argument. To align with this, invert the boolean values
> used when calling verify_counters() within the end_server() function.

Hi Dmitry,

I see that this is correct, but I am wondering
if it fixes a user-visible bug. If so, could
some text about that go here?

> 
> Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test")
> Signed-off-by: Mohammad Nassiri <[email-masked]>
> Link: https://lore.kernel.org/all/[email-masked]/
> [amended 'Fixes' tag and carried-over to lkml]
> Signed-off-by: Dmitry Safonov <[email-masked]>

...