Subject: Re: [PATCH net v2] selftests: net: fix rps_default_mask with >32 CPUs

From: Simon Horman <[email-masked]>
Date: Sun, 21 Jan 2024 20:34:33 +0000

On Sat, Jan 20, 2024 at 01:02:56PM -0800, Jakub Kicinski wrote:
> If there is more than 32 cpus the bitmask will start to contain
> commas, leading to:
> 
> ./rps_default_mask.sh: line 36: [: 00000000,00000000: integer expression expected
> 
> Remove the commas, bash doesn't interpret leading zeroes as oct
> so that should be good enough.
> 
> Fixes: c12e0d5f267d ("self-tests: introduce self-tests for RPS default mask")
> Signed-off-by: Jakub Kicinski <[email-masked]>
> ---
> v2:
>  - remove all commas
> v1: https://lore.kernel.org/all/[email-masked]/

Thanks,

this version looks good to me.

Reviewed-by: Simon Horman <[email-masked]>