Subject: Re: [PATCH net-next 14/22] net: fill in MODULE_DESCRIPTION()s for ocelot

From: Alexandre Belloni <[email-masked]>
Date: Tue, 23 Jan 2024 08:48:26 +0100

Hello,

On 22/01/2024 10:45:35-0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.
> 
> Signed-off-by: Breno Leitao <[email-masked]>
> ---
>  drivers/net/ethernet/mscc/ocelot.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> index 56ccbd4c37fe..12999d9be3af 100644
> --- a/drivers/net/ethernet/mscc/ocelot.c
> +++ b/drivers/net/ethernet/mscc/ocelot.c
> @@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
>  }
>  EXPORT_SYMBOL(ocelot_deinit_port);
>  
> +MODULE_DESCRIPTION("Ocelot SoCs (VSC7514) helpers");

Shouldn't that mention that this is related to the Ethernet switch?

>  MODULE_LICENSE("Dual MIT/GPL");
> -- 
> 2.39.3
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com