Subject: Re: [PATCH] netfilter: nf_tables: Add a null pointer check in two functions

From: Simon Horman <[email-masked]>
Date: Tue, 23 Jan 2024 17:46:25 +0000

On Tue, Jan 23, 2024 at 02:45:12PM +0100, Markus Elfring wrote:
> From: Markus Elfring <[email-masked]>
> Date: Tue, 23 Jan 2024 14:28:31 +0100
> 
> The result from a call of the function “kasprintf” was passed to
> a subsequent function call without checking for a null pointer before
> (according to a memory allocation failure).
> This issue was detected by using the Coccinelle software.
> 
> Thus add a null pointer check and a jump target in affected functions.
> 
> Fixes: 8877393029e76 ("netfilter: nf_tables: Open-code audit log call in nf_tables_getrule()")
> Fixes: 0854db2aaef3f ("netfilter: nf_tables: use net_generic infra for transaction data")
> Signed-off-by: Markus Elfring <[email-masked]>

For the record:

Markus has posed patches of this nature many times over the past weeks
and months. They are not fixing bugs - there is no user visible problem.
And moreover they move the code away from the preferred style -
avoiding unnecessary checks around code that can handle NULL values.

Markus, please stop posting patches of this nature.