Subject: Re: [PATCH net] ipmr: fix kernel panic when forwarding mcast packets

From: Jakub Kicinski <[email-masked]>
Date: Wed, 24 Jan 2024 15:23:13 -0800

On Wed, 24 Jan 2024 13:15:38 +0100 Nicolas Dichtel wrote:
> --- a/net/ipv4/ip_sockglue.c
> +++ b/net/ipv4/ip_sockglue.c
> @@ -1368,7 +1368,7 @@ int do_ip_setsockopt(struct sock *sk, int level, int optname,
>   * destination in skb->cb[] before dst drop.
>   * This way, receiver doesn't make cache line misses to read rtable.
>   */
> -void ipv4_pktinfo_prepare(const struct sock *sk, struct sk_buff *skb)
> +void ipv4_pktinfo_prepare(const struct sock *sk, struct sk_buff *skb, bool keep_dst)

kdoc missing here:

net/ipv4/ip_sockglue.c:1373: warning: Function parameter or struct member 'keep_dst' not described in 'ipv4_pktinfo_prepare'
-- 
pw-bot: cr