Subject: Re: [PATCH v3 net-next] taprio: validate TCA_TAPRIO_ATTR_FLAGS through policy instead of open-coding

From: Simon Horman <[email-masked]>
Date: Fri, 26 Jan 2024 21:14:41 +0000

On Thu, Jan 25, 2024 at 05:59:42PM +0100, Alessandro Marcolini wrote:
> As of now, the field TCA_TAPRIO_ATTR_FLAGS is being validated by manually
> checking its value, using the function taprio_flags_valid().
> 
> With this patch, the field will be validated through the netlink policy
> NLA_POLICY_MASK, where the mask is defined by TAPRIO_SUPPORTED_FLAGS.
> The mutual exclusivity of the two flags TCA_TAPRIO_ATTR_FLAG_FULL_OFFLOAD
> and TCA_TAPRIO_ATTR_FLAG_TXTIME_ASSIST is still checked manually.
> 
> Changes since RFC:
> - fixed reversed xmas tree
> - use NL_SET_ERR_MSG_MOD() for both invalid configuration
> 
> Changes since v1:
> - Changed NL_SET_ERR_MSG_MOD to NL_SET_ERR_MSG_ATTR when wrong flags
>   issued
> - Changed __u32 to u32
> 
> Changes since v2:
> - Added the missing parameter for NL_SET_ERR_MSG_ATTR (sorry again for
>   the noise)
> 
> Signed-off-by: Alessandro Marcolini <[email-masked]>
> ---

Thanks for the updates.

Reviewed-by: Simon Horman <[email-masked]>

For reference, and I don't think it's probably not
necessary to repost because of this, these days
it is normal to put the Changes below the scissors (---).
This means they don't end up in the git history.
But now we have lore that seems to be less of an issue.