From: Simon Horman <horms@kernel•org>
To: Breno Leitao <leitao@debian•org>
Cc: kuba@kernel•org, davem@davemloft•net, pabeni@redhat•com,
edumazet@google•com, Vladimir Oltean <vladimir.oltean@nxp•com>,
Claudiu Manoil <claudiu.manoil@nxp•com>,
Alexandre Belloni <alexandre.belloni@bootlin•com>,
UNGLinuxDriver@microchip•com, dsahern@kernel•org,
weiwan@google•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
Horatiu Vultur <horatiu.vultur@microchip•com>
Subject: Re: [PATCH net 02/10] net: fill in MODULE_DESCRIPTION()s for ocelot
Date: Tue, 30 Jan 2024 10:11:34 +0000 [thread overview]
Message-ID: <20240130101134.GG349047@kernel.org> (raw)
In-Reply-To: <20240125193420.533604-3-leitao@debian.org>
On Thu, Jan 25, 2024 at 11:34:12AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.
>
> Signed-off-by: Breno Leitao <leitao@debian•org>
> Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip•com>
> ---
> drivers/net/ethernet/mscc/ocelot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> index 56ccbd4c37fe..2194f2a7ab27 100644
> --- a/drivers/net/ethernet/mscc/ocelot.c
> +++ b/drivers/net/ethernet/mscc/ocelot.c
> @@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
> }
> EXPORT_SYMBOL(ocelot_deinit_port);
>
> +MODULE_DESCRIPTION("Microsemi Ocelot (VSC7514) Switch driver");
Hi Breno,
I really appreciate your work in this area.
WRT this patch, I could well be wrong, but I think this code is also used
by Felix (VSC9959). If so the description might want tweaking.
Vladimir, can you shed some light on this?
> MODULE_LICENSE("Dual MIT/GPL");
> --
> 2.39.3
>
next prev parent reply other threads:[~2024-01-30 10:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
2024-01-25 19:34 ` [PATCH net 01/10] net: fill in MODULE_DESCRIPTION()s for encx24j600 Breno Leitao
2024-01-30 12:54 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 02/10] net: fill in MODULE_DESCRIPTION()s for ocelot Breno Leitao
2024-01-30 10:11 ` Simon Horman [this message]
2024-01-30 12:03 ` Vladimir Oltean
2024-01-25 19:34 ` [PATCH net 03/10] net: fill in MODULE_DESCRIPTION()s for SMSC drivers Breno Leitao
2024-01-30 12:55 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 04/10] net: fill in MODULE_DESCRIPTION()s for Qualcom drivers Breno Leitao
2024-01-30 12:56 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 05/10] net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga Breno Leitao
2024-01-30 12:56 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 06/10] net: fill in MODULE_DESCRIPTION()s for cpsw-common Breno Leitao
2024-01-30 12:57 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 07/10] net: fill in MODULE_DESCRIPTION()s for ec_bhf Breno Leitao
2024-01-30 12:57 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 08/10] net: fill in MODULE_DESCRIPTION()s for PCS drivers Breno Leitao
2024-01-25 21:26 ` Andrew Lunn
2024-01-25 19:34 ` [PATCH net 09/10] net: fill in MODULE_DESCRIPTION()s for ieee802154 Breno Leitao
2024-01-25 19:34 ` [PATCH net 10/10] net: fill in MODULE_DESCRIPTION()s for arcnet Breno Leitao
2024-01-30 12:57 ` Simon Horman
2024-01-29 12:20 ` [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) patchwork-bot+netdevbpf
2024-01-29 20:00 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130101134.GG349047@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=horatiu.vultur@microchip$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leitao@debian$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=weiwan@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox