Subject: Re: [PATCH iwl-next v4 3/3] ixgbe: Clarify the values of the returning status

From: Simon Horman <[email-masked]>
Date: Tue, 30 Jan 2024 13:11:37 +0000

On Fri, Jan 26, 2024 at 02:05:03PM +0100, Jedrzej Jagielski wrote:
> Converting s32 functions to regular int in the previous patch of the series
> caused triggering smatch warnings about missing error code.
> 
> New smatch warnings:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2884 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status'
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:3130 ixgbe_enter_lplu_t_x550em() warn: missing error code? 'status'
> 
> Old smatch warnings:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2890 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status'
> 
> Fix it by clearly stating returning error code as 0.
> 
> Reported-by: kernel test robot <[email-masked]>
> Reported-by: Dan Carpenter <[email-masked]>
> Closes: https://lore.kernel.org/r/[email-masked]/
> Signed-off-by: Jedrzej Jagielski <[email-masked]>

Thanks, nice to see this cleaned up.

Reviewed-by: Simon Horman <[email-masked]>