From: Jakub Kicinski <kuba@kernel•org>
To: Paolo Abeni <pabeni@redhat•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>, Shuah Khan <shuah@kernel•org>,
Xin Long <lucien.xin@gmail•com>, Florian Westphal <fw@strlen•de>,
Aaron Conole <aconole@redhat•com>,
Nikolay Aleksandrov <razor@blackwall•org>,
linux-kselftest@vger•kernel.org
Subject: Re: [PATCH net] selftests: net: add missing config for big tcp tests
Date: Tue, 30 Jan 2024 17:18:17 -0800 [thread overview]
Message-ID: <20240130171817.1572c29f@kernel.org> (raw)
In-Reply-To: <785a9d7b1ce68f8131e6f9c8802981ac7ad75948.camel@redhat.com>
On Tue, 30 Jan 2024 19:41:10 +0100 Paolo Abeni wrote:
> > Yes, it's VM inside a VM without nested virtualization support.
> > A weird setup, granted, but when we move to bare metal I'd like
> > to enable KASAN, which will probably cause a similar slowdown..
> >
> > You could possibly get a similar slowdown by disabling HW virt /
> > KVM?
>
> Thanks, the above helped - that is, I can reproduce the failure running
> the self-tests in a VM with KVM disabled in the host. Funnily enough I
> can't use plain virtme for that - the virtme VM crashes on boot,
> possibly due to the wrong 'machine' argument passed to qemu.
FWIW I think you can fix this by passing -o " -cpu Haswell" to vng.
Yet another piece of knowledge I wish I didn't have and which I should
probably put somewhere public :(
> In any case I can't see a sane way to cope with such slow environments
> except skipping the sensitive cases.
>
> > FWIW far the 4 types of issues we've seen were:
> > - config missing
> > - OS doesn't ifup by default
> > - OS tools are old / buggy
> > - VM-in-VM is just too slow.
> >
> > There's a bunch of failures in forwarding which look like perf issues.
> > I wonder if we should introduce something in the settings file to let
> > tests know that they are running in very slow env?
>
> I was wondering about passing such info to the test e.g. via an env
> variable:
>
> vng --run . --user root -- HOST_IS_DAMN_SLOW=true
> ./tools/testing/selftests/kselftest_install/run_kselftest.sh -t
> <whatever>
>
> In any case some tests should be updated to skip the relevant cases
> accordingly, right?
Which reminds me I need to send the meeting notes from the netdev call
:) We went with KSFT_MACHINE_SLOW=yes for now, the NIPA machines should
have it set now.
prev parent reply other threads:[~2024-01-31 1:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 15:32 [PATCH net] selftests: net: add missing config for big tcp tests Paolo Abeni
2024-01-26 16:18 ` Aaron Conole
2024-01-26 16:55 ` Paolo Abeni
2024-01-26 16:43 ` Xin Long
2024-01-26 19:55 ` Jakub Kicinski
2024-01-29 9:11 ` Paolo Abeni
2024-01-29 16:31 ` Paolo Abeni
2024-01-29 16:39 ` Jakub Kicinski
2024-01-30 18:41 ` Paolo Abeni
2024-01-31 1:18 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130171817.1572c29f@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=aconole@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox