From: Jakub Kicinski <kuba@kernel•org>
To: Hangbin Liu <liuhangbin@gmail•com>
Cc: netdev@vger•kernel.org, Jay Vosburgh <j.vosburgh@gmail•com>,
"David S . Miller" <davem@davemloft•net>,
Paolo Abeni <pabeni@redhat•com>,
Eric Dumazet <edumazet@google•com>, Liang Li <liali@redhat•com>,
Przemek Kitszel <przemyslaw.kitszel@intel•com>
Subject: Re: [PATCHv4 net-next 4/4] selftests: bonding: use slowwait instead of hard code sleep
Date: Sun, 4 Feb 2024 08:28:58 -0800 [thread overview]
Message-ID: <20240204082858.2d823ef5@kernel.org> (raw)
In-Reply-To: <20240204085128.1512341-5-liuhangbin@gmail.com>
On Sun, 4 Feb 2024 16:51:28 +0800 Hangbin Liu wrote:
> Use slowwait instead of hard code sleep for bonding tests.
>
> In function setup_prepare(), the client_create() will be called after
> server_create(). So I think there is no need to sleep in server_create()
> and remove it.
>
> For lab_lib.sh, remove bonding module may affect other running bonding tests.
> And some test env may buildin bond which can't be removed. The bonding
> link should be removed by lag_reset_network() or netns delete.
Unfortunately still fails here 4/10 runs :(
Did you try to repro with virtme-ng, --disable-kvm and many CPUs?
--
pw-bot: cr
next prev parent reply other threads:[~2024-02-04 16:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 8:51 [PATCHv4 net-next 0/4] selftests: bonding: use slowwait when waiting Hangbin Liu
2024-02-04 8:51 ` [PATCHv4 net-next 1/4] selftests/net/forwarding: add slowwait functions Hangbin Liu
2024-02-04 8:51 ` [PATCHv4 net-next 2/4] selftests: bonding: use tc filter to check if LACP was sent Hangbin Liu
2024-02-04 8:51 ` [PATCHv4 net-next 3/4] selftests: bonding: reduce garp_test/arp_validate test time Hangbin Liu
2024-02-04 8:51 ` [PATCHv4 net-next 4/4] selftests: bonding: use slowwait instead of hard code sleep Hangbin Liu
2024-02-04 16:28 ` Jakub Kicinski [this message]
2024-02-05 12:46 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240204082858.2d823ef5@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=liali@redhat$(echo .)com \
--cc=liuhangbin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox