Subject: Re: [PATCH net] selftests: cmsg_ipv6: repeat the exact packet

From: Simon Horman <[email-masked]>
Date: Tue, 6 Feb 2024 18:08:38 +0000

On Sun, Feb 04, 2024 at 08:56:18AM -0800, Jakub Kicinski wrote:
> cmsg_ipv6 test requests tcpdump to capture 4 packets,
> and sends until tcpdump quits. Only the first packet
> is "real", however, and the rest are basic UDP packets.
> So if tcpdump doesn't start in time it will miss
> the real packet and only capture the UDP ones.
> 
> This makes the test fail on slow machine (no KVM or with
> debug enabled) 100% of the time, while it passes in fast
> environments.
> 
> Repeat the "real" / expected packet.
> 
> Fixes: 9657ad09e1fa ("selftests: net: test IPV6_TCLASS")
> Signed-off-by: Jakub Kicinski <[email-masked]>

I'm not sure if it is important, but doesn't this also:

Fixes: 05ae83d5a4a2 ("selftests: net: test IPV6_HOPLIMIT")

In any case, this looks good to me.

Reviewed-by: Simon Horman <[email-masked]>