From: Jakub Kicinski <kuba@kernel•org>
To: Joe Damato <jdamato@fastly•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
chuck.lever@oracle•com, jlayton@kernel•org,
linux-api@vger•kernel.org, brauner@kernel•org,
edumazet@google•com, davem@davemloft•net,
alexander.duyck@gmail•com, sridhar.samudrala@intel•com,
willemdebruijn.kernel@gmail•com, weiwan@google•com,
David.Laight@ACULAB•COM, arnd@arndb•de, sdf@google•com,
amritha.nambiar@intel•com, Jonathan Corbet <corbet@lwn•net>,
Alexander Viro <viro@zeniv•linux.org.uk>, Jan Kara <jack@suse•cz>,
Nathan Lynch <nathanl@linux•ibm.com>,
Michael Ellerman <mpe@ellerman•id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Namjae Jeon <linkinjeon@kernel•org>,
Steve French <stfrench@microsoft•com>,
Thomas Zimmermann <tzimmermann@suse•de>,
Julien Panis <jpanis@baylibre•com>,
Andrew Waterman <waterman@eecs•berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt•com>,
Albert Ou <aou@eecs•berkeley.edu>,
"open list:DOCUMENTATION" <linux-doc@vger•kernel.org>,
"open list:FILESYSTEMS (VFS and infrastructure)"
<linux-fsdevel@vger•kernel.org>
Subject: Re: [PATCH net-next v6 4/4] eventpoll: Add epoll ioctl for epoll_params
Date: Wed, 7 Feb 2024 11:07:26 -0800 [thread overview]
Message-ID: <20240207110726.68c07188@kernel.org> (raw)
In-Reply-To: <20240207185014.GA1221@fastly.com>
On Wed, 7 Feb 2024 10:50:15 -0800 Joe Damato wrote:
> > This !! is unnecessary. Nonzero values shall be "converted" to true.
> >
> > But FWIW, the above is nothing which should be blocking, so:
> ">
> > Reviewed-by: Jiri Slaby <jirislaby@kernel•org>
>
> netdev maintainers: Jiri marked this with Reviewed-by, but was this review
> what caused "Changes Requested" to be the status set for this patch set in
> patchwork?
>
> If needed, I'll send a v7 with the changes Jiri suggested and add the
> "Reviewed-by" since the changes are cosmetic, but I wanted to make sure
> this was the reason.
Yes, I think that's it.
next prev parent reply other threads:[~2024-02-07 19:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 21:04 [PATCH net-next v6 0/4] Per epoll context busy poll support Joe Damato
2024-02-05 21:04 ` [PATCH net-next v6 1/4] eventpoll: support busy poll per epoll instance Joe Damato
2024-02-07 19:04 ` Jakub Kicinski
2024-02-07 19:14 ` Joe Damato
2024-02-07 20:11 ` Jakub Kicinski
2024-02-07 20:23 ` Joe Damato
2024-02-07 20:56 ` Jakub Kicinski
2024-02-08 17:46 ` Eric Dumazet
2024-02-08 18:06 ` Joe Damato
2024-02-05 21:04 ` [PATCH net-next v6 2/4] eventpoll: Add per-epoll busy poll packet budget Joe Damato
2024-02-07 19:04 ` Jakub Kicinski
2024-02-08 17:47 ` Eric Dumazet
2024-02-05 21:04 ` [PATCH net-next v6 3/4] eventpoll: Add per-epoll prefer busy poll option Joe Damato
2024-02-07 19:04 ` Jakub Kicinski
2024-02-08 17:49 ` Eric Dumazet
2024-02-05 21:04 ` [PATCH net-next v6 4/4] eventpoll: Add epoll ioctl for epoll_params Joe Damato
2024-02-07 8:37 ` Jiri Slaby
2024-02-07 18:50 ` Joe Damato
2024-02-07 19:07 ` Jakub Kicinski [this message]
2024-02-07 19:16 ` Joe Damato
2024-02-07 20:18 ` Jakub Kicinski
2024-02-06 18:51 ` [PATCH net-next v6 0/4] Per epoll context busy poll support Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207110726.68c07188@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=David.Laight@ACULAB$(echo .)COM \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=amritha.nambiar@intel$(echo .)com \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=arnd@arndb$(echo .)de \
--cc=brauner@kernel$(echo .)org \
--cc=chuck.lever@oracle$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jack@suse$(echo .)cz \
--cc=jdamato@fastly$(echo .)com \
--cc=jlayton@kernel$(echo .)org \
--cc=jpanis@baylibre$(echo .)com \
--cc=linkinjeon@kernel$(echo .)org \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=nathanl@linux$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=palmer@dabbelt$(echo .)com \
--cc=sdf@google$(echo .)com \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=stfrench@microsoft$(echo .)com \
--cc=tzimmermann@suse$(echo .)de \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=waterman@eecs$(echo .)berkeley.edu \
--cc=weiwan@google$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox