From: Simon Horman <horms@kernel•org>
To: Victor Nogueira <victor@mojatatu•com>
Cc: jhs@mojatatu•com, xiyou.wangcong@gmail•com, jiri@resnulli•us,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, netdev@vger•kernel.org, kernel@mojatatu•com,
pctammela@mojatatu•com
Subject: Re: [PATCH net v2] net/sched: act_mirred: Don't zero blockid when net device is being deleted
Date: Fri, 9 Feb 2024 09:41:43 +0000 [thread overview]
Message-ID: <20240209094143.GT1435458@kernel.org> (raw)
In-Reply-To: <20240207222902.1469398-1-victor@mojatatu.com>
On Wed, Feb 07, 2024 at 07:29:02PM -0300, Victor Nogueira wrote:
> While testing tdc with parallel tests for mirred to block we caught an
> intermittent bug. The blockid was being zeroed out when a net device
> was deleted and, thus, giving us an incorrect blockid value whenever
> we tried to dump the mirred action. Since we don't increment the block
> refcount in the control path (and only use the ID), we don't need to
> zero the blockid field whenever a net device is going down.
>
> Fixes: 42f39036cda8 ("net/sched: act_mirred: Allow mirred to block")
> Signed-off-by: Victor Nogueira <victor@mojatatu•com>
> ---
> v1 -> v2:
> - Reword commit message to emphasise the bug is caused when a net
> device is being deleted
> - Reword subject to emphasise the bug is caused when a net device is
> being deleted. Original patch subject was:
> "net/sched: act_mirred: Don't zero blockid when netns is going down"
Thanks for the update.
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2024-02-09 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 22:29 [PATCH net v2] net/sched: act_mirred: Don't zero blockid when net device is being deleted Victor Nogueira
2024-02-09 9:41 ` Simon Horman [this message]
2024-02-09 10:30 ` Eric Dumazet
2024-02-09 11:28 ` Jamal Hadi Salim
2024-02-09 21:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209094143.GT1435458@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kernel@mojatatu$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pctammela@mojatatu$(echo .)com \
--cc=victor@mojatatu$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox