Subject: Re: [PATCH net-next v4 05/17] net: pse-pd: Introduce PSE types enumeration

From: Jakub Kicinski <[email-masked]>
Date: Thu, 15 Feb 2024 10:58:46 -0800

On Thu, 15 Feb 2024 17:02:46 +0100 Kory Maincent wrote:
> Introduce an enumeration to define PSE types (C33 or PoDL),
> utilizing a bitfield for potential future support of both types.
> Include 'pse_get_types' helper for external access to PSE type info.

I haven't read the series, just noticed this breaks the build:

error: ../include/uapi/linux/pse.h: missing "WITH Linux-syscall-note" for SPDX-License-Identifier

but why the separate header? Is it going to be used in other parts of
uAPI than just in ethtool?

> This patch is sponsored by Dent Project <[email-masked]>

side-note: no objections to the line but for accounting purposes
(i.e. when we generate development stats) we use the Author / From
line exclusively. So it'd be easier to compute stats of things funded
by Dent if you used:

From: Kory Maincent (Dent Project) <[email-masked]>

but that's entirely up to you :)