Subject: Re: [patch net-next] devlink: fix port dump cmd type

From: Simon Horman <[email-masked]>
Date: Mon, 19 Feb 2024 15:13:43 +0000

On Fri, Feb 16, 2024 at 12:31:47PM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <[email-masked]>
> 
> Unlike other commands, due to a c&p error, port dump fills-up cmd with
> wrong value, different from port-get request cmd, port-get doit reply
> and port notification.
> 
> Fix it by filling cmd with value DEVLINK_CMD_PORT_NEW.
> 
> Skimmed through devlink userspace implementations, none of them cares
> about this cmd value. Only ynl, for which, this is actually a fix, as it
> expects doit and dumpit ops rsp_value to be the same.

I guess that in theory unknown implementations could exist.
But, ok :)

> 
> Omit the fixes tag, even thought this is fix, better to target this for
> next release.
> 
> Signed-off-by: Jiri Pirko <[email-masked]>

Reviewed-by: Simon Horman <[email-masked]>