Subject: Re: [PATCH] wifi: mac80211: clean up assignments to pointer cache.

From: Simon Horman <[email-masked]>
Date: Mon, 19 Feb 2024 16:08:22 +0000

On Thu, Feb 15, 2024 at 11:21:51PM +0000, Colin Ian King wrote:
> From: Colin Ian King <[email-masked]>
> 
> The assignment to pointer cache in function mesh_fast_tx_gc can
> be made at the declaration time rather than a later assignment.
> There are also 3 functions where pointer cache is being initialized
> at declaration time and later re-assigned again with the same
> value, these are redundant and can be removed.
> 
> Cleans up code and three clang scan build warnings:
> warning: Value stored to 'cache' during its initialization is never
> read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <[email-masked]>

FWIIW, these changes look fine to me although I might have split the
mesh_fast_tx_gc() and mesh_fast_tx_flush_sta() changes into different
patches as they seem to address separate issues.

That notwithstanding,

Reviewed-by: Simon Horman <[email-masked]>