From: kovalev@altlinux•org
To: netdev@vger•kernel.org
Cc: pabeni@redhat•com, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, jiri@resnulli•us, jacob.e.keller@intel•com,
johannes@sipsolutions•net, idosch@nvidia•com,
kovalev@altlinux•org, horms@kernel•org,
david.lebrun@uclouvain•be, pablo@netfilter•org
Subject: [PATCH net ver.2] genetlink: fix possible use-after-free and null-ptr-deref in genl_dumpit()
Date: Tue, 20 Feb 2024 13:25:12 +0300 [thread overview]
Message-ID: <20240220102512.104452-1-kovalev@altlinux.org> (raw)
From: Vasiliy Kovalev <kovalev@altlinux•org>
The pernet operations structure for the subsystem must be registered
before registering the generic netlink family.
Introduced in commit 134e63756d5f ("genetlink: make netns aware")
Signed-off-by: Vasiliy Kovalev <kovalev@altlinux•org>
---
net/netlink/genetlink.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
index 8c7af02f845400..20a7d792dd52ec 100644
--- a/net/netlink/genetlink.c
+++ b/net/netlink/genetlink.c
@@ -1879,14 +1879,14 @@ static int __init genl_init(void)
{
int err;
- err = genl_register_family(&genl_ctrl);
- if (err < 0)
- goto problem;
-
err = register_pernet_subsys(&genl_pernet_ops);
if (err)
goto problem;
+ err = genl_register_family(&genl_ctrl);
+ if (err < 0)
+ goto problem;
+
return 0;
problem:
--
2.33.8
next reply other threads:[~2024-02-20 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 10:25 kovalev [this message]
2024-02-20 10:36 ` [PATCH net ver.2] genetlink: fix possible use-after-free and null-ptr-deref in genl_dumpit() Pablo Neira Ayuso
2024-02-20 11:03 ` kovalev
2024-02-22 1:23 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220102512.104452-1-kovalev@altlinux.org \
--to=kovalev@altlinux$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=david.lebrun@uclouvain$(echo .)be \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=idosch@nvidia$(echo .)com \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox