Subject: Re: [RFC PATCH v3 net-next] Documentation: devlink: Add devlink-sd

From: Jakub Kicinski <[email-masked]>
Date: Tue, 20 Feb 2024 14:17:09 -0800

On Mon, 19 Feb 2024 10:06:17 +0100 Jiri Pirko wrote:
> >Gluing to the device is easier, IIUC, once the pool is create we can
> >give it whatever attributes we want. devlink ID, bus/device, netdev,
> >IOMMU domain, anything.  
> 
> I'm confused. Above (***) you say that the shared pool is created upon
> first netdev creation. Now you indicate the user creates it and then
> "binds" it to some object (like devlink).
> 
> So, do you think there should be 2 types of pools:
> 1) implicit upon netdev creation
> 2) explicit defined by the user?

Implicitly, "once the pool is create[d]" does not say that user created
the pool. The flow would be more like:
 - user changes configuration "rules"
 - if device is running && config changed:
   - core instantiates the new pools
   - core issues "reset" request to the device to rebuild queues
   - core shuts down old pools