From: Halil Pasic <pasic@linux•ibm.com>
To: Xuan Zhuo <xuanzhuo@linux•alibaba.com>
Cc: "Jason Wang" <jasowang@redhat•com>,
virtualization@lists•linux.dev,
"Richard Weinberger" <richard@nod•at>,
"Anton Ivanov" <anton.ivanov@cambridgegreys•com>,
"Johannes Berg" <johannes@sipsolutions•net>,
"Michael S. Tsirkin" <mst@redhat•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Hans de Goede" <hdegoede@redhat•com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux•intel.com>,
"Vadim Pasternak" <vadimp@nvidia•com>,
"Bjorn Andersson" <andersson@kernel•org>,
"Mathieu Poirier" <mathieu.poirier@linaro•org>,
"Cornelia Huck" <cohuck@redhat•com>,
"Eric Farman" <farman@linux•ibm.com>,
"Heiko Carstens" <hca@linux•ibm.com>,
"Vasily Gorbik" <gor@linux•ibm.com>,
"Alexander Gordeev" <agordeev@linux•ibm.com>,
"Christian Borntraeger" <borntraeger@linux•ibm.com>,
"Sven Schnelle" <svens@linux•ibm.com>,
"Alexei Starovoitov" <ast@kernel•org>,
"Daniel Borkmann" <daniel@iogearbox•net>,
"Jesper Dangaard Brouer" <hawk@kernel•org>,
"John Fastabend" <john.fastabend@gmail•com>,
"Benjamin Berg" <benjamin.berg@intel•com>,
"Yang Li" <yang.lee@linux•alibaba.com>,
linux-um@lists•infradead.org, netdev@vger•kernel.org,
platform-driver-x86@vger•kernel.org,
linux-remoteproc@vger•kernel.org, linux-s390@vger•kernel.org,
kvm@vger•kernel.org, bpf@vger•kernel.org,
"Halil Pasic" <pasic@linux•ibm.com>
Subject: Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters
Date: Tue, 20 Feb 2024 15:18:15 +0100 [thread overview]
Message-ID: <20240220151815.5c867cce.pasic@linux.ibm.com> (raw)
In-Reply-To: <1706756442.5524123-1-xuanzhuo@linux.alibaba.com>
On Thu, 1 Feb 2024 11:00:42 +0800
Xuan Zhuo <xuanzhuo@linux•alibaba.com> wrote:
> > > And squish the parameters from transport to a structure.
> >
> > The patch did more than what is described here, it also switch to use
> > a structure for vring_create_virtqueue() etc.
> >
> > Is it better to split?
>
> Sure.
I understand there will be a v2. From virtio-ccw perspective I have
no objections.
Regards,
Halil
next prev parent reply other threads:[~2024-02-20 14:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 11:42 [PATCH vhost 00/17] virtio: drivers maintain dma info for premapped vq Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 01/17] virtio_ring: introduce vring_need_unmap_buffer Xuan Zhuo
2024-01-31 9:12 ` Jason Wang
2024-01-30 11:42 ` [PATCH vhost 02/17] virtio_ring: packed: remove double check of the unmap ops Xuan Zhuo
2024-01-31 9:12 ` Jason Wang
2024-01-31 9:58 ` Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 03/17] virtio_ring: packed: structure the indirect desc table Xuan Zhuo
2024-01-31 9:12 ` Jason Wang
2024-01-31 10:00 ` Xuan Zhuo
2024-02-01 0:41 ` Jason Wang
2024-01-30 11:42 ` [PATCH vhost 04/17] virtio_ring: split: remove double check of the unmap ops Xuan Zhuo
2024-01-31 9:12 ` Jason Wang
2024-01-31 9:43 ` Michael S. Tsirkin
2024-02-01 5:47 ` Jason Wang
2024-02-01 6:43 ` Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 05/17] virtio_ring: split: structure the indirect desc table Xuan Zhuo
2024-01-31 9:12 ` Jason Wang
2024-01-30 11:42 ` [PATCH vhost 06/17] virtio_ring: no store dma info when unmap is not needed Xuan Zhuo
2024-01-31 9:12 ` Jason Wang
2024-02-01 6:04 ` Xuan Zhuo
2024-02-02 3:04 ` Jason Wang
2024-01-30 11:42 ` [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters Xuan Zhuo
2024-01-31 9:12 ` Jason Wang
2024-02-01 3:00 ` Xuan Zhuo
2024-02-20 14:18 ` Halil Pasic [this message]
2024-02-21 2:03 ` Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 08/17] virtio: vring_new_virtqueue(): " Xuan Zhuo
2024-01-31 9:12 ` Jason Wang
2024-01-31 11:03 ` Ilpo Järvinen
2024-02-01 2:24 ` Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 09/17] virtio_ring: reuse the parameter struct of find_vqs() Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 10/17] virtio: find_vqs: add new parameter premapped Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 11/17] virtio_ring: export premapped to driver by struct virtqueue Xuan Zhuo
2024-01-31 9:12 ` Jason Wang
2024-02-01 3:17 ` Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 12/17] virtio_net: set premapped mode by find_vqs() Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 13/17] virtio_ring: remove api of setting vq premapped Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 14/17] virtio_ring: introduce dma map api for page Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 15/17] virtio_net: unify the code for recycling the xmit ptr Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 16/17] virtio_net: rename free_old_xmit_skbs to free_old_xmit Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 17/17] virtio_net: sq support premapped mode Xuan Zhuo
2024-01-31 9:12 ` Jason Wang
2024-02-01 3:21 ` Xuan Zhuo
2024-02-01 5:36 ` Jason Wang
2024-02-01 5:56 ` Xuan Zhuo
2024-02-02 3:06 ` Jason Wang
2024-02-01 7:43 ` [PATCH vhost 00/17] virtio: drivers maintain dma info for premapped vq Zhu Yanjun
2024-02-01 9:57 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220151815.5c867cce.pasic@linux.ibm.com \
--to=pasic@linux$(echo .)ibm.com \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=andersson@kernel$(echo .)org \
--cc=anton.ivanov@cambridgegreys$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=benjamin.berg@intel$(echo .)com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=cohuck@redhat$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=farman@linux$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=hawk@kernel$(echo .)org \
--cc=hca@linux$(echo .)ibm.com \
--cc=hdegoede@redhat$(echo .)com \
--cc=ilpo.jarvinen@linux$(echo .)intel.com \
--cc=jasowang@redhat$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-remoteproc@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-um@lists$(echo .)infradead.org \
--cc=mathieu.poirier@linaro$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=richard@nod$(echo .)at \
--cc=svens@linux$(echo .)ibm.com \
--cc=vadimp@nvidia$(echo .)com \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
--cc=yang.lee@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox