Subject: Re: [PATCH net-next v3 10/11] selftests: kselftest_harness: support using xfail

From: Kees Cook <[email-masked]>
Date: Tue, 20 Feb 2024 16:52:07 -0800

On Tue, Feb 20, 2024 at 11:22:34AM -0800, Jakub Kicinski wrote:
> Currently some tests report skip for things they expect to fail
> e.g. when given combination of parameters is known to be unsupported.
> This is confusing because in an ideal test environment and fully
> featured kernel no tests should be skipped.
> 
> Selftest summary line already includes xfail and xpass counters,
> e.g.:
> 
> but there's no way to use it from within the harness.
> 
> Add a new per-fixture+variant combination list of test cases
> we expect to fail.
> 
> Signed-off-by: Jakub Kicinski <[email-masked]>

Thanks for this implementation; this will work nicely. :)

Reviewed-by: Kees Cook <[email-masked]>

-- 
Kees Cook