Subject: Re: [PATCH net-next v6] bonding: rate-limit bonding driver inspect messages

From: Simon Horman <[email-masked]>
Date: Wed, 21 Feb 2024 10:38:53 +0000

On Wed, Feb 21, 2024 at 01:57:52PM +0530, Praveen Kumar Kannoju wrote:
> Through the routine bond_mii_monitor(), bonding driver inspects and commits
> the slave state changes. During the times when slave state change and
> failure in aqcuiring rtnl lock happen at the same time, the routine
> bond_mii_monitor() reschedules itself to come around after 1 msec to commit
> the new state.
> 
> During this, it executes the routine bond_miimon_inspect() to re-inspect
> the state chane and prints the corresponding slave state on to the console.
> Hence we do see a message at every 1 msec till the rtnl lock is acquired
> and state chage is committed.
> 
> This patch doesn't change how bond functions. It only simply limits this
> kind of log flood.
> 
> Signed-off-by: Praveen Kumar Kannoju <[email-masked]>
> ---
> v6: 
>   - Minor space additions addressed. 
> v5: https://lore.kernel.org/all/[email-masked]/
>   - Redundant indentation addressed.
> v4: https://lore.kernel.org/all/[email-masked]/
>   - Rectification in the patch subject and versioning details.
> v3: https://lore.kernel.org/lkml/[email-masked]/
>   - Commit message is modified to provide summary of the issue, because of
>     which rate-limiting the bonding driver messages is needed.
> v2: https://lore.kernel.org/lkml/[email-masked]/
>   - Use exising net_ratelimit() instead of introducing new rate-limit
>     parameter.
> v1: https://lore.kernel.org/lkml/[email-masked]/
> ---
>  drivers/net/bonding/bond_main.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)

Hi Praveen,

Thanks for addressing my review of v4.
This version looks good to me.

Reviewed-by: Simon Horman <[email-masked]>

...