Subject: Re: [PATCH net-next v4 5/7] net: stmmac: Signal to PHY/PCS drivers to keep RX clock on

From: Jakub Kicinski <[email-masked]>
Date: Wed, 21 Feb 2024 11:14:44 -0800

On Wed, 21 Feb 2024 14:04:22 +0100 Romain Gantois wrote:
> There is a reocurring issue with stmmac controllers where the MAC fails to
> initialize its hardware if an RX clock signal isn't provided on the MAC/PHY
> link.
> 
> This causes issues when PHY or PCS devices either go into suspend while
> cutting the RX clock or do not bring the clock signal up early enough for
> the MAC to initialize successfully.
> 
> Set the mac_requires_rxc flag in the stmmac phylink config so that PHY/PCS
> drivers know to keep the RX clock up at all times.
> 
> Reported-by: Clark Wang <[email-masked]>
> Link: https://lore.kernel.org/all/[email-masked]/
> Reported-by: Clément Léger <[email-masked]>
> Link: https://lore.kernel.org/linux-arm-kernel/[email-masked]/
> Suggested-by: Russell King <[email-masked]>
> Signed-off-by: Romain Gantois <[email-masked]>

breaks allmodconfig:

ERROR: modpost: "phylink_pcs_pre_init" [drivers/net/ethernet/stmicro/stmmac/stmmac.ko] undefined!
-- 
pw-bot: cr