Subject: Re: [PATCH v2] net: stmmac: mmc_core: Drop interrupt registers from stats

From: Jesper Nilsson <[email-masked]>
Date: Thu, 22 Feb 2024 11:28:08 +0100

On Thu, Feb 22, 2024 at 10:38:53AM +0100, Paolo Abeni wrote:
> On Tue, 2024-02-20 at 13:00 +0100, Jesper Nilsson wrote:
> > The MMC IPC interrupt status and interrupt mask registers are
> > of little use as Ethernet statistics, but incrementing counters
> > based on the current interrupt and interrupt mask registers
> > makes them actively misleading.
> > 
> > For example, if the interrupt mask is set to 0x08420842,
> > the current code will increment by that amount each iteration,
> > leading to the following sequence of nonsense:
> > 
> > mmc_rx_ipc_intr_mask: 969816526
> > mmc_rx_ipc_intr_mask: 1108361744
> > 
> > These registers have been included in the Ethernet statistics
> > since the first version of MMC back in 2011 (commit 1c901a46d57).
> > That commit also mentions the MMC interrupts as
> > "something to add later (if actually useful)".
> > 
> > If the registers are actually useful, they should probably
> > be part of the Ethernet register dump instead of statistics,
> > but for now, drop the counters for mmc_rx_ipc_intr and
> > mmc_rx_ipc_intr_mask completely.
> > 
> > Signed-off-by: Jesper Nilsson <[email-masked]>
> 
> It looks like this could target the 'net' tree. Anyway it does not
> apply cleanly to 'net' nor 'net-next'. Could you please rebase &&
> repost, including Serge's tags and explicitly setting the target tree
> into the subj prefix?

Yeah, will do. My v1 patch applied cleanly to net-next,
but I didn't check the v2. My bad.

> Thanks!
> Paolo

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- [email-masked]