From: Jakub Kicinski <kuba@kernel•org>
To: thinker.li@gmail•com
Cc: netdev@vger•kernel.org, ast@kernel•org, martin.lau@linux•dev,
kernel-team@meta•com, davem@davemloft•net, dsahern@kernel•org,
edumazet@google•com, pabeni@redhat•com, liuhangbin@gmail•com,
sinquersw@gmail•com, kuifeng@meta•com
Subject: Re: [PATCH net-next v6 5/5] selftests/net: Adding test cases of replacing routes and route advertisements.
Date: Thu, 22 Feb 2024 19:52:24 -0800 [thread overview]
Message-ID: <20240222195224.7ff5c5e0@kernel.org> (raw)
In-Reply-To: <20240208220653.374773-6-thinker.li@gmail.com>
On Thu, 8 Feb 2024 14:06:53 -0800 thinker.li@gmail•com wrote:
> # Permanent routes
> - for i in $(seq 1 5000); do
> + for i in $(seq 1 5); do
> $IP -6 route add 2001:30::$i \
> via 2001:10::2 dev dummy_10
> done
> # Temporary routes
> - for i in $(seq 1 1000); do
> + for i in $(seq 1 5); do
> # Expire route after $EXPIRE seconds
> $IP -6 route add 2001:20::$i \
> via 2001:10::2 dev dummy_10 expires $EXPIRE
> done
> - sleep $(($EXPIRE * 2))
> - N_EXP_SLEEP=$($IP -6 route list |grep expires|wc -l)
> - if [ $N_EXP_SLEEP -ne 0 ]; then
> - echo "FAIL: expected 0 routes with expires," \
> - "got $N_EXP_SLEEP (5000 permanent routes)"
> - ret=1
> - else
> - ret=0
> + sleep $(($EXPIRE * 2 + 1))
> + check_rt_num 0 $($IP -6 route list |grep expires|wc -l)
> + log_test $ret 0 "ipv6 route garbage collection (with permanent routes)"
Looks like fib_tests.sh have gotten flaky since this got merged :(
https://netdev.bots.linux.dev/contest.html?test=fib-tests-sh&executor=vmksft-net&pass=0
# Fib6 garbage collection test
# TEST: ipv6 route garbage collection [ OK ]
# FAIL: Expected 0 routes, got 1
# TEST: ipv6 route garbage collection (with permanent routes) [FAIL]
# TEST: ipv6 route garbage collection (replace with expires) [ OK ]
# TEST: ipv6 route garbage collection (replace with permanent) [ OK ]
https://netdev-3.bots.linux.dev/vmksft-net/results/477081/6-fib-tests-sh/stdout
# Fib6 garbage collection test
# TEST: ipv6 route garbage collection [ OK ]
# FAIL: Expected 0 routes, got 3
# TEST: ipv6 route garbage collection (with permanent routes) [FAIL]
# TEST: ipv6 route garbage collection (replace with expires) [ OK ]
# TEST: ipv6 route garbage collection (replace with permanent) [ OK ]
https://netdev-3.bots.linux.dev/vmksft-net/results/467181/6-fib-tests-sh/stdout
# Fib6 garbage collection test
# TEST: ipv6 route garbage collection [ OK ]
# FAIL: Expected 0 routes, got 3
# TEST: ipv6 route garbage collection (with permanent routes) [FAIL]
# TEST: ipv6 route garbage collection (replace with expires) [ OK ]
# TEST: ipv6 route garbage collection (replace with permanent) [ OK ]
https://netdev-3.bots.linux.dev/vmksft-net/results/466641/18-fib-tests-sh/stdout
Could you take a look?
next prev parent reply other threads:[~2024-02-23 3:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 22:06 [PATCH net-next v6 0/5] Remove expired routes with a separated list of routes thinker.li
2024-02-08 22:06 ` [PATCH net-next v6 1/5] net/ipv6: set expires in rt6_add_dflt_router() thinker.li
2024-02-08 22:06 ` [PATCH net-next v6 2/5] net/ipv6: Remove unnecessary clean thinker.li
2024-02-08 22:06 ` [PATCH net-next v6 3/5] net/ipv6: Remove expired routes with a separated list of routes thinker.li
2024-02-08 22:06 ` [PATCH net-next v6 4/5] net/ipv6: set expires in modify_prefix_route() if RTF_EXPIRES is set thinker.li
2024-02-08 22:06 ` [PATCH net-next v6 5/5] selftests/net: Adding test cases of replacing routes and route advertisements thinker.li
2024-02-23 3:52 ` Jakub Kicinski [this message]
2024-02-23 4:53 ` Kui-Feng Lee
2024-02-12 10:30 ` [PATCH net-next v6 0/5] Remove expired routes with a separated list of routes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222195224.7ff5c5e0@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=kernel-team@meta$(echo .)com \
--cc=kuifeng@meta$(echo .)com \
--cc=liuhangbin@gmail$(echo .)com \
--cc=martin.lau@linux$(echo .)dev \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sinquersw@gmail$(echo .)com \
--cc=thinker.li@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox