Subject: Re: [PATCH v2 net-next 3/3] net: Use backlog-NAPI to clean up the defer_list.

From: Jakub Kicinski <[email-masked]>
Date: Fri, 23 Feb 2024 18:02:57 -0800

On Wed, 21 Feb 2024 18:00:13 +0100 Sebastian Andrzej Siewior wrote:
> +	if (use_backlog_threads()) {
> +		rps_lock_irqsave(sd, &flags);
> +
> +		if (!__test_and_set_bit(NAPI_STATE_SCHED, &sd->backlog.state))
> +			napi_schedule_rps(sd);

Why are you calling napi_schedule_rps() here?
Just do __napi_schedule_irqoff(&sd->backlog);
Then you can move the special case inside napi_schedule_rps()
into the if (sd != mysd) block.

> +		rps_unlock_irq_restore(sd, &flags);

Also not sure if the lock helpers should still be called RPS since they
also protect state on non-RPS configs now.