From: Jakub Kicinski <kuba@kernel•org>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com,
amritha.nambiar@intel•com, danielj@nvidia•com, mst@redhat•com,
michael.chan@broadcom•com, sdf@google•com,
vadim.fedorenko@linux•dev, Jakub Kicinski <kuba@kernel•org>
Subject: [PATCH net-next 2/3] netdev: add queue stat for alloc failures
Date: Mon, 26 Feb 2024 13:10:14 -0800 [thread overview]
Message-ID: <20240226211015.1244807-3-kuba@kernel.org> (raw)
In-Reply-To: <20240226211015.1244807-1-kuba@kernel.org>
Rx alloc failures are commonly counted by drivers.
Support reporting those via netdev-genl queue stats.
Signed-off-by: Jakub Kicinski <kuba@kernel•org>
---
Documentation/netlink/specs/netdev.yaml | 7 +++++++
include/net/netdev_queues.h | 2 ++
include/uapi/linux/netdev.h | 1 +
net/core/netdev-genl.c | 3 ++-
tools/include/uapi/linux/netdev.h | 1 +
5 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml
index 2570cc371fc8..382a98383b6e 100644
--- a/Documentation/netlink/specs/netdev.yaml
+++ b/Documentation/netlink/specs/netdev.yaml
@@ -328,6 +328,13 @@ name: netdev
name: tx-bytes
doc: Successfully sent bytes, see `tx-packets`.
type: uint
+ -
+ name: rx-alloc-fail
+ doc: |
+ Number of times skb or buffer allocation failed on the Rx datapath.
+ Allocation failure may, or may not result in a packet drop, depending
+ on driver implementation and whether system recovers quickly.
+ type: uint
operations:
list:
diff --git a/include/net/netdev_queues.h b/include/net/netdev_queues.h
index d633347eeda5..1ec408585373 100644
--- a/include/net/netdev_queues.h
+++ b/include/net/netdev_queues.h
@@ -4,9 +4,11 @@
#include <linux/netdevice.h>
+/* See the netdev.yaml spec for definition of each statistic */
struct netdev_queue_stats_rx {
u64 bytes;
u64 packets;
+ u64 alloc_fail;
};
struct netdev_queue_stats_tx {
diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h
index f282634e031d..6e7a0e74ccd6 100644
--- a/include/uapi/linux/netdev.h
+++ b/include/uapi/linux/netdev.h
@@ -145,6 +145,7 @@ enum {
NETDEV_A_STATS_RX_BYTES,
NETDEV_A_STATS_TX_PACKETS,
NETDEV_A_STATS_TX_BYTES,
+ NETDEV_A_STATS_RX_ALLOC_FAIL,
__NETDEV_A_STATS_MAX,
NETDEV_A_STATS_MAX = (__NETDEV_A_STATS_MAX - 1)
diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c
index 0fbd666f2b79..db72c4801d5c 100644
--- a/net/core/netdev-genl.c
+++ b/net/core/netdev-genl.c
@@ -498,7 +498,8 @@ static int
netdev_nl_stats_write_rx(struct sk_buff *rsp, struct netdev_queue_stats_rx *rx)
{
if (netdev_stat_put(rsp, NETDEV_A_STATS_RX_PACKETS, rx->packets) ||
- netdev_stat_put(rsp, NETDEV_A_STATS_RX_BYTES, rx->bytes))
+ netdev_stat_put(rsp, NETDEV_A_STATS_RX_BYTES, rx->bytes) ||
+ netdev_stat_put(rsp, NETDEV_A_STATS_RX_ALLOC_FAIL, rx->alloc_fail))
return -EMSGSIZE;
return 0;
}
diff --git a/tools/include/uapi/linux/netdev.h b/tools/include/uapi/linux/netdev.h
index f282634e031d..6e7a0e74ccd6 100644
--- a/tools/include/uapi/linux/netdev.h
+++ b/tools/include/uapi/linux/netdev.h
@@ -145,6 +145,7 @@ enum {
NETDEV_A_STATS_RX_BYTES,
NETDEV_A_STATS_TX_PACKETS,
NETDEV_A_STATS_TX_BYTES,
+ NETDEV_A_STATS_RX_ALLOC_FAIL,
__NETDEV_A_STATS_MAX,
NETDEV_A_STATS_MAX = (__NETDEV_A_STATS_MAX - 1)
--
2.43.2
next prev parent reply other threads:[~2024-02-26 21:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 21:10 [PATCH net-next 0/3] netdev: add per-queue statistics Jakub Kicinski
2024-02-26 21:10 ` [PATCH net-next 1/3] " Jakub Kicinski
2024-02-26 21:35 ` Stanislav Fomichev
2024-02-26 22:19 ` Jakub Kicinski
2024-02-27 3:37 ` Stanislav Fomichev
2024-02-27 15:24 ` Jakub Kicinski
2024-02-27 18:09 ` Stanislav Fomichev
2024-02-27 19:49 ` Nambiar, Amritha
2024-02-27 10:29 ` Przemek Kitszel
2024-02-27 15:00 ` Jakub Kicinski
2024-02-27 16:17 ` Przemek Kitszel
2024-02-27 23:01 ` Jakub Kicinski
2024-02-26 21:10 ` Jakub Kicinski [this message]
2024-02-26 21:10 ` [PATCH net-next 3/3] eth: bnxt: support " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226211015.1244807-3-kuba@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=amritha.nambiar@intel$(echo .)com \
--cc=danielj@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sdf@google$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox