Subject: Re: [PATCH net-next v2 1/4] devlink: add two info version tags

From: Jakub Kicinski <[email-masked]>
Date: Wed, 28 Feb 2024 20:32:35 -0800

On Wed, 28 Feb 2024 13:14:43 +0100 Jiri Pirko wrote:
> >+/* Part number for entire product */
> >+#define DEVLINK_INFO_VERSION_GENERIC_PART_NUMBER       "part_number"  
> 
> /* Part number, identifier of board design */
> #define DEVLINK_INFO_VERSION_GENERIC_BOARD_ID   "board.id"
> 
> Isn't this what you are looking for?

My memory is fading but AFAIR when I added the other IDs, back in my
Netronome days, the expectation was that they would be combined
together to form the part number.

Not sure why they need a separate one now, maybe they lost the docs,
maybe requirements changed. Would be good to know... :)

> "part_number" without domain (boards/asic/fw) does not look correct to
> me. "Product" sounds very odd.

I believe Part Number is what PCI VPD calls it.

In addition to Jiri's questions:

> +/* Model of the board */
> +#define DEVLINK_INFO_VERSION_GENERIC_BOARD_MODEL       "board.model"

What's the difference between this and:

 board.id
 --------
 
 Unique identifier of the board design.

? One is AMDA the other one is code name?
You gotta provide more guidance how the two differ...