Subject: Re: [RESEND] dt-bindings: leds: pwm-multicolour: re-allow active-low

From: Lee Jones <[email-masked]>
Date: Fri, 1 Mar 2024 07:59:35 +0000

On Thu, 29 Feb 2024, Conor Dooley wrote:

> From: Conor Dooley <[email-masked]>
> 
> active-low was lifted to the common schema for leds, but it went
> unnoticed that the leds-multicolour binding had "additionalProperties:
> false" where the other users had "unevaluatedProperties: false", thereby
> disallowing active-low for multicolour leds. Explicitly permit it again.
> 
> Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common")
> Acked-by: Rob Herring <[email-masked]>
> Signed-off-by: Conor Dooley <[email-masked]>
> ---
> 
> This needs to go via netdev as the commit it fixes (and is based on)
> is there
> 
> CC: Pavel Machek <[email-masked]>
> CC: Lee Jones <[email-masked]>
> CC: Rob Herring <[email-masked]>
> CC: Krzysztof Kozlowski <[email-masked]>
> CC: Conor Dooley <[email-masked]>
> CC: Sven Schwermer <[email-masked]>
> CC: Christian Marangi <[email-masked]>
> CC: [email-masked]
> CC: [email-masked]
> CC: [email-masked]
> CC: "David S. Miller" <[email-masked]>
> CC: Eric Dumazet <[email-masked]>
> CC: Jakub Kicinski <[email-masked]>
> CC: Paolo Abeni <[email-masked]>
> CC: [email-masked]
> ---
>  Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Please take this via netdev.

Acked-by: Lee Jones <[email-masked]>

> diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> index 5edfbe347341..a31a202afe5c 100644
> --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> @@ -41,6 +41,8 @@ properties:
>  
>            pwm-names: true
>  
> +          active-low: true
> +
>            color: true
>  
>          required:
> -- 
> 2.43.0
> 
> 

-- 
Lee Jones [李琼斯]