From: Simon Horman <horms@kernel•org>
To: Alex Elder <elder@linaro•org>
Cc: davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, mka@chromium•org, andersson@kernel•org,
quic_cpratapa@quicinc•com, quic_avuyyuru@quicinc•com,
quic_jponduru@quicinc•com, quic_subashab@quicinc•com,
elder@kernel•org, netdev@vger•kernel.org,
linux-arm-msm@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next 1/7] net: ipa: change ipa_interrupt_config() prototype
Date: Fri, 1 Mar 2024 16:26:28 +0000 [thread overview]
Message-ID: <20240301162628.GF403078@kernel.org> (raw)
In-Reply-To: <20240229205554.86762-2-elder@linaro.org>
On Thu, Feb 29, 2024 at 02:55:48PM -0600, Alex Elder wrote:
> Change the return type of ipa_interrupt_config() to be an error
> code rather than an IPA interrupt structure pointer, and assign the
> the pointer within that function.
>
> Change ipa_interrupt_deconfig() to take the IPA pointer as argument
> and have it invalidate the ipa->interrupt pointer.
>
> Signed-off-by: Alex Elder <elder@linaro•org>
> ---
> drivers/net/ipa/ipa_interrupt.c | 15 ++++++++++-----
> drivers/net/ipa/ipa_interrupt.h | 10 +++++-----
> drivers/net/ipa/ipa_main.c | 13 ++++---------
> 3 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_interrupt.c b/drivers/net/ipa/ipa_interrupt.c
> index 4d80bf77a5323..a298d922dd871 100644
> --- a/drivers/net/ipa/ipa_interrupt.c
> +++ b/drivers/net/ipa/ipa_interrupt.c
> @@ -236,7 +236,7 @@ void ipa_interrupt_simulate_suspend(struct ipa_interrupt *interrupt)
> }
>
> /* Configure the IPA interrupt framework */
> -struct ipa_interrupt *ipa_interrupt_config(struct ipa *ipa)
> +int ipa_interrupt_config(struct ipa *ipa)
Hi Alex,
There are two cases where this function still returns a pointer.
Around line 250:
ret = platform_get_irq_byname(ipa->pdev, "ipa");
if (ret <= 0) {
dev_err(dev, "DT error %d getting \"ipa\" IRQ property\n",
ret);
return ERR_PTR(ret ? : -EINVAL);
}
And around line 280:
return interrupt;
This does seem to be resolved in patch 2/7.
But as it is, this patch breaks bisection.
...
next prev parent reply other threads:[~2024-03-01 16:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 20:55 [PATCH net-next 0/7] net: ipa: simplify device pointer access Alex Elder
2024-02-29 20:55 ` [PATCH net-next 1/7] net: ipa: change ipa_interrupt_config() prototype Alex Elder
2024-03-01 16:26 ` Simon Horman [this message]
2024-03-01 16:37 ` Alex Elder
2024-03-04 16:24 ` Simon Horman
2024-02-29 20:55 ` [PATCH net-next 2/7] net: ipa: introduce ipa_interrupt_init() Alex Elder
2024-02-29 20:55 ` [PATCH net-next 3/7] net: ipa: pass a platform device to ipa_reg_init() Alex Elder
2024-02-29 20:55 ` [PATCH net-next 4/7] net: ipa: pass a platform device to ipa_mem_init() Alex Elder
2024-02-29 20:55 ` [PATCH net-next 5/7] net: ipa: pass a platform device to ipa_smp2p_irq_init() Alex Elder
2024-02-29 20:55 ` [PATCH net-next 6/7] net: ipa: pass a platform device to ipa_smp2p_init() Alex Elder
2024-02-29 20:55 ` [PATCH net-next 7/7] net: ipa: don't save the platform device Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301162628.GF403078@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andersson@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=elder@kernel$(echo .)org \
--cc=elder@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mka@chromium$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=quic_avuyyuru@quicinc$(echo .)com \
--cc=quic_cpratapa@quicinc$(echo .)com \
--cc=quic_jponduru@quicinc$(echo .)com \
--cc=quic_subashab@quicinc$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox