From: Simon Horman <horms@kernel•org>
To: Tony Nguyen <anthony.l.nguyen@intel•com>
Cc: davem@davemloft•net, kuba@kernel•org, pabeni@redhat•com,
edumazet@google•com, netdev@vger•kernel.org,
Maciej Fijalkowski <maciej.fijalkowski@intel•com>,
Przemek Kitszel <przemyslaw.kitszel@intel•com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel•com>
Subject: Re: [PATCH net-next 9/9] ice: avoid unnecessary devm_ usage
Date: Tue, 5 Mar 2024 12:18:58 +0000 [thread overview]
Message-ID: <20240305121858.GA2357@kernel.org> (raw)
In-Reply-To: <20240304212932.3412641-10-anthony.l.nguyen@intel.com>
On Mon, Mar 04, 2024 at 01:29:30PM -0800, Tony Nguyen wrote:
> From: Maciej Fijalkowski <maciej.fijalkowski@intel•com>
>
> 1. pcaps are free'd right after AQ routines are done, no need for
> devm_'s
> 2. a test frame for loopback test in ethtool -t is destroyed at the end
> of the test so we don't need devm_ here either.
>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel•com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel•com>
> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel•com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel•com>
FWIIW, I did look over this patch and it looks good to me.
next prev parent reply other threads:[~2024-03-05 12:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 21:29 [PATCH net-next 0/9][pull request] Intel Wired LAN Driver Updates 2024-03-04 (ice) Tony Nguyen
2024-03-04 21:29 ` [PATCH net-next 1/9] ice: pass VSI pointer into ice_vc_isvalid_q_id Tony Nguyen
2024-03-04 21:29 ` [PATCH net-next 2/9] ice: remove unnecessary duplicate checks for VF VSI ID Tony Nguyen
2024-03-04 21:29 ` [PATCH net-next 3/9] ice: use relative VSI index for VFs instead of PF VSI number Tony Nguyen
2024-03-04 21:29 ` [PATCH net-next 4/9] ice: remove vf->lan_vsi_num field Tony Nguyen
2024-03-04 21:29 ` [PATCH net-next 5/9] ice: rename ice_write_* functions to ice_pack_ctx_* Tony Nguyen
2024-03-04 21:29 ` [PATCH net-next 6/9] ice: use GENMASK instead of BIT(n) - 1 in pack functions Tony Nguyen
2024-03-04 21:29 ` [PATCH net-next 7/9] ice: cleanup line splitting for context set functions Tony Nguyen
2024-03-04 21:29 ` [PATCH net-next 8/9] ice: do not disable Tx queues twice in ice_down() Tony Nguyen
2024-03-04 21:29 ` [PATCH net-next 9/9] ice: avoid unnecessary devm_ usage Tony Nguyen
2024-03-05 12:18 ` Simon Horman [this message]
2024-03-06 11:30 ` [PATCH net-next 0/9][pull request] Intel Wired LAN Driver Updates 2024-03-04 (ice) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305121858.GA2357@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=himasekharx.reddy.pucha@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox