Subject: Re: [PATCH] selftests/harness: Fix TEST_F()'s vfork handling

From: Kees Cook <[email-masked]>
Date: Tue, 5 Mar 2024 12:31:47 -0800

On Tue, Mar 05, 2024 at 09:10:29PM +0100, Mickaël Salaün wrote:
> Always run fixture setup in the grandchild process, and by default also
> run the teardown in the same process.  However, this change makes it
> possible to run the teardown in a parent process when
> _metadata->teardown_parent is set to true (e.g. in fixture setup).
> 
> Fix TEST_SIGNAL() by forwarding grandchild's signal to its parent.  Fix
> seccomp tests by running the test setup in the parent of the test
> thread, as expected by the related test code.  Fix Landlock tests by
> waiting for the grandchild before processing _metadata.
> 
> Use of exit(3) in tests should be OK because the environment in which
> the vfork(2) call happen is already dedicated to the running test (with
> flushed stdio, setpgrp() call), see __run_test() and the call to fork(2)
> just before running the setup/test/teardown.  Even if the test
> configures its own exit handlers, they will not be run by the parent
> because it never calls exit(3), and the test function either ends with a
> call to _exit(2) or a signal.
> 
> Cc: David S. Miller <[email-masked]>
> Cc: Günther Noack <[email-masked]>
> Cc: Jakub Kicinski <[email-masked]>
> Cc: Kees Cook <[email-masked]>
> Cc: Mark Brown <[email-masked]>
> Cc: Shuah Khan <[email-masked]>
> Cc: Will Drewry <[email-masked]>
> Fixes: 0710a1a73fb4 ("selftests/harness: Merge TEST_F_FORK() into TEST_F()")
> Link: https://lore.kernel.org/r/[email-masked]

Sanity-check run of seccomp tests before:

# # Totals: pass:70 fail:21 xfail:0 xpass:0 skip:5 error:0

After:

# # Totals: pass:91 fail:0 xfail:0 xpass:0 skip:5 error:0

Reviewed-by: Kees Cook <[email-masked]>
Tested-by: Kees Cook <[email-masked]>

Thanks for a quick fix!

-Kees

-- 
Kees Cook