From: Jakub Kicinski <kuba@kernel•org>
To: Jiri Pirko <jiri@resnulli•us>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
pabeni@redhat•com, Geert Uytterhoeven <geert@linux-m68k•org>,
vadim.fedorenko@linux•dev, arkadiusz.kubalewski@intel•com
Subject: Re: [PATCH net v2] dpll: move all dpll<>netdev helpers to dpll code
Date: Tue, 5 Mar 2024 18:38:15 -0800 [thread overview]
Message-ID: <20240305183815.1b23ab51@kernel.org> (raw)
In-Reply-To: <ZebMG4gDnX4Wuh-B@nanopsycho>
On Tue, 5 Mar 2024 08:39:07 +0100 Jiri Pirko wrote:
> >-EXPORT_SYMBOL_GPL(dpll_msg_add_pin_handle);
> >+
> >+static struct dpll_pin *netdev_dpll_pin(const struct net_device *dev)
>
> You may add "dpll_" prefix to this helper as well to be aligned with the
> rest while you are at it. Take it or leave it.
> Patch looks fine.
Fixed when applying, hope that's okay. I want to make sure it sits
in net for a few days before we submit it to Linus.
next prev parent reply other threads:[~2024-03-06 2:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 1:35 [PATCH net v2] dpll: move all dpll<>netdev helpers to dpll code Jakub Kicinski
2024-03-05 7:39 ` Jiri Pirko
2024-03-06 2:38 ` Jakub Kicinski [this message]
2024-03-05 18:52 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305183815.1b23ab51@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=arkadiusz.kubalewski@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox