Subject: Re: [EXTERNAL] Re: [PATCH v6 1/5] net: wan: Add support for QMC HDLC

From: Herve Codina <[email-masked]>
Date: Wed, 6 Mar 2024 18:46:11 +0100

Hi Jakub,

On Wed, 6 Mar 2024 08:22:30 -0800
Jakub Kicinski <[email-masked]> wrote:

> On Wed, 6 Mar 2024 16:01:48 +0000 Ratheesh Kannoth wrote:
> > > > > +	struct qmc_hdlc_desc *desc = context;
> > > > > +	struct net_device *netdev = desc->netdev;
> > > > > +	struct qmc_hdlc *qmc_hdlc = netdev_to_qmc_hdlc(netdev);    
> > > > Reverse xmas tree    
> > > 
> > > The reverse xmas tree order cannot be used here.
> > > qmc_hdlc depends on netdev, netdev depends on desc.
> > >     
> > ACK. Usually I get comments to split declaration and assignment for
> > my patches in upstream.   
> 
> Yup, that's our general preference, to split the init out of 
> the definition.

Does it mean that I need to update in a next iteration ?

Best regards,
Hervé