From: Jakub Kicinski <kuba@kernel•org>
To: Jiri Pirko <jiri@resnulli•us>
Cc: netdev@vger•kernel.org, pabeni@redhat•com, davem@davemloft•net,
edumazet@google•com, arkadiusz.kubalewski@intel•com,
vadim.fedorenko@linux•dev
Subject: Re: [patch net-next] dpll: spec: use proper enum for pin capabilities attribute
Date: Wed, 6 Mar 2024 20:27:24 -0800 [thread overview]
Message-ID: <20240306202724.670fb304@kernel.org> (raw)
In-Reply-To: <20240306120739.1447621-1-jiri@resnulli.us>
On Wed, 6 Mar 2024 13:07:39 +0100 Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia•com>
>
> The enum is defined, however the pin capabilities attribute does
> refer to it. Add this missing enum field.
>
> This fixes ynl cli output:
>
> Example current output:
> $ sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0}'
> {'capabilities': 4,
> ...
> Example new output:
> $ sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0}'
> {'capabilities': {'state-can-change'},
> ...
>
> Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
> Signed-off-by: Jiri Pirko <jiri@nvidia•com>
Reviewed-by: Jakub Kicinski <kuba@kernel•org>
next prev parent reply other threads:[~2024-03-07 4:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 12:07 [patch net-next] dpll: spec: use proper enum for pin capabilities attribute Jiri Pirko
2024-03-06 15:25 ` Jiri Pirko
2024-03-06 15:34 ` Jakub Kicinski
2024-03-13 14:26 ` Jakub Kicinski
2024-03-13 14:58 ` Jiri Pirko
2024-03-13 15:31 ` Jakub Kicinski
2024-03-14 8:42 ` Jiri Pirko
2024-03-07 4:27 ` Jakub Kicinski [this message]
2024-03-08 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306202724.670fb304@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=arkadiusz.kubalewski@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox