Subject: Re: [PATCH] net: wan: framer/pef2256: Convert to platform remove callback returning void

From: Herve Codina <[email-masked]>
Date: Fri, 8 Mar 2024 14:43:40 +0100

Hi Uwe,

On Fri,  8 Mar 2024 09:51:09 +0100
Uwe Kleine-König <[email-masked]> wrote:

> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <[email-masked]>
> ---

Thanks for the patch.

Acked-by: Herve Codina <[email-masked]>

Regards,
Hervé